Skip to content

make survey more prominent #2037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
samccann merged 3 commits into from
Oct 23, 2024
Merged

make survey more prominent #2037

samccann merged 3 commits into from
Oct 23, 2024

Conversation

@samccann
Copy link
Contributor

@samccann samccann commented Oct 22, 2024

Not getting enuf responses through the docs so... BIGGER IS BETTER!

@samccann samccann requested a review from oraNod October 22, 2024 20:14
@samccann samccann added backport-2.17 Automatically create a backport for the stable-2.17 branch backport-2.18 Automatically create a backport for the stable-2.18 branch labels Oct 22, 2024
@samccann
Copy link
Contributor Author

samccann commented Oct 22, 2024

Current banner:
image

New banner (with this PR):
image

oraNod
oraNod reviewed Oct 23, 2024
View reviewed changes
Copy link
Contributor

@oraNod oraNod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to set the text size in relative units rather than a percentage. If it's a percentage then it doesn't allow fonts to scale predictably. There's also an accessibility concern here. WCAG recommends text can be resized up to 200%.

Another thing is that percentages are relative to the font size of the parent element so the size could actually be greater than 130%. I didn't go so far as to actually try and figure out what it is when rendered though.

@samccann
Copy link
Contributor Author

samccann commented Oct 23, 2024

Thanks @oraNod for the suggested edits and explanations! Here's what it looks like now with the suggested changes:
image

oraNod
oraNod approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@oraNod oraNod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed a couple of leading spaces but LGTM otherwise. Thanks @samccann

@samccann samccann closed this Oct 23, 2024
@samccann samccann reopened this Oct 23, 2024
@samccann samccann merged commit 764d4ce into ansible:devel Oct 23, 2024
18 of 20 checks passed
@patchback
Copy link

patchback bot commented Oct 23, 2024 •
edited
Loading

Backport to stable-2.17: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.17/764d4ce617fc8d13d603b5ef36e42ed4f7074b7e/pr-2037

Backported as #2045

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 23, 2024
@samccann @oraNod @patchback
make survey more prominent (#2037)
e808c2d 
* make survey more prominent

* Apply suggestions from code review

Co-authored-by: Don Naro <[email protected]>

* Apply suggestions from code review

Co-authored-by: Don Naro <[email protected]>

---------

Co-authored-by: Don Naro <[email protected]>
(cherry picked from commit 764d4ce)
@patchback patchback bot mentioned this pull request Oct 23, 2024
Merged
@patchback
Copy link

patchback bot commented Oct 23, 2024 •
edited
Loading

Backport to stable-2.18: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.18/764d4ce617fc8d13d603b5ef36e42ed4f7074b7e/pr-2037

Backported as #2046

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 23, 2024
@samccann @oraNod @patchback
make survey more prominent (#2037)
1a56edd 
* make survey more prominent

* Apply suggestions from code review

Co-authored-by: Don Naro <[email protected]>

* Apply suggestions from code review

Co-authored-by: Don Naro <[email protected]>

---------

Co-authored-by: Don Naro <[email protected]>
(cherry picked from commit 764d4ce)
@patchback patchback bot mentioned this pull request Oct 23, 2024
Merged
samccann added a commit that referenced this pull request Oct 23, 2024
@patchback @samccann
make survey more prominent (#2037) (#2045)
0e2524b 
* make survey more prominent

* Apply suggestions from code review

Co-authored-by: Don Naro <[email protected]>

* Apply suggestions from code review

Co-authored-by: Don Naro <[email protected]>

---------

Co-authored-by: Don Naro <[email protected]>
(cherry picked from commit 764d4ce)

Co-authored-by: Sandra McCann <[email protected]>
oraNod pushed a commit that referenced this pull request Oct 24, 2024
@patchback @samccann
make survey more prominent (#2037) (#2046)
f0c7a13 
* make survey more prominent

* Apply suggestions from code review

Co-authored-by: Don Naro <[email protected]>

* Apply suggestions from code review

Co-authored-by: Don Naro <[email protected]>

---------

Co-authored-by: Don Naro <[email protected]>
(cherry picked from commit 764d4ce)

Co-authored-by: Sandra McCann <[email protected]>
oraNod added a commit that referenced this pull request Nov 25, 2024
@samccann @oraNod
make survey more prominent (#2037)
c47559b 
* make survey more prominent

* Apply suggestions from code review

Co-authored-by: Don Naro <[email protected]>

* Apply suggestions from code review

Co-authored-by: Don Naro <[email protected]>

---------

Co-authored-by: Don Naro <[email protected]>
@samccann samccann deleted the banner-fun branch February 14, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oraNod oraNod oraNod approved these changes

Assignees

No one assigned

Labels

backport-2.17 Automatically create a backport for the stable-2.17 branch backport-2.18 Automatically create a backport for the stable-2.18 branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@samccann @oraNod