Skip to content

Added 2.18 porting guide #2076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
samccann merged 3 commits into from
Oct 29, 2024
Merged

Added 2.18 porting guide #2076

samccann merged 3 commits into from
Oct 29, 2024

Conversation

@jborean93
Copy link
Contributor

@jborean93 jborean93 commented Oct 28, 2024

@jborean93 jborean93 mentioned this pull request Oct 28, 2024
Closed
1 task
@felixfontein
Copy link
Collaborator

felixfontein commented Oct 28, 2024

The docs build checker failure is because the 2.18 porting guide isn't mentioned in docs/docsite/rst/porting_guides/core_porting_guides.rst.

@jborean93
Copy link
Contributor Author

jborean93 commented Oct 28, 2024

Thanks, just running the checks locally because it looks like there may be other formatting problems? I've fixed the toctree entry though so hopefully that's it.

@felixfontein
Copy link
Collaborator

felixfontein commented Oct 28, 2024

The pip-compile error is unrelated, please ignore it.

@jborean93
Copy link
Contributor Author

jborean93 commented Oct 28, 2024

Removed the assertion changes entry as the underlying changelog entry is being removed ansible/ansible#84187.

@felixfontein felixfontein added the backport-2.18 Automatically create a backport for the stable-2.18 branch label Oct 29, 2024
@gotmax23 gotmax23 mentioned this pull request Oct 29, 2024
Merged
@samccann
Copy link
Contributor

samccann commented Oct 29, 2024

@felixfontein is the pip compile error the reason why the docsite CI/check also fails? aka can I merge this beastie?

@felixfontein
Copy link
Collaborator

felixfontein commented Oct 29, 2024

@samccann yes, that's the only reason why it fails; if there will be no more changes/reviews from Core's side or your side, feel free to merge this :)

samccann
samccann reviewed Oct 29, 2024
View reviewed changes
Copy link
Contributor

@samccann samccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple of nits. Thanks for this!

@samccann samccann merged commit d6eb6c9 into ansible:devel Oct 29, 2024
11 checks passed
@patchback
Copy link

patchback bot commented Oct 29, 2024 •
edited
Loading

Backport to stable-2.18: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.18/d6eb6c9b1465b619bd001b43755e004417d658ad/pr-2076

Backported as #2091

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 29, 2024
@jborean93 @samccann @patchback
Added 2.18 porting guide (#2076)
d302d23 
* Added 2.18 porting guide

* Removed assertion change from porting guide

* Apply suggestions from code review

Co-authored-by: Sandra McCann <[email protected]>

---------

Co-authored-by: Sandra McCann <[email protected]>
(cherry picked from commit d6eb6c9)
@patchback patchback bot mentioned this pull request Oct 29, 2024
Merged
felixfontein pushed a commit that referenced this pull request Oct 29, 2024
@patchback @jborean93
Added 2.18 porting guide (#2076) (#2091)
c5d519d 
* Added 2.18 porting guide

* Removed assertion change from porting guide

* Apply suggestions from code review

Co-authored-by: Sandra McCann <[email protected]>

---------

Co-authored-by: Sandra McCann <[email protected]>
(cherry picked from commit d6eb6c9)

Co-authored-by: Jordan Borean <[email protected]>
@jborean93 jborean93 deleted the 2.18-porting branch October 29, 2024 21:56
@jborean93
Copy link
Contributor Author

jborean93 commented Oct 29, 2024

Thanks for the review and help.

oraNod pushed a commit that referenced this pull request Nov 25, 2024
@jborean93 @samccann @oraNod
Added 2.18 porting guide (#2076)
6cd4209 
* Added 2.18 porting guide

* Removed assertion change from porting guide

* Apply suggestions from code review

Co-authored-by: Sandra McCann <[email protected]>

---------

Co-authored-by: Sandra McCann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samccann samccann samccann approved these changes

Assignees

No one assigned

Labels

backport-2.18 Automatically create a backport for the stable-2.18 branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

There is still no ansible-core 2.18 porting guide

3 participants

@jborean93 @felixfontein @samccann