-
Notifications
You must be signed in to change notification settings - Fork 687
Add yamllint check for RST code listings #2385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
622bd57
Add yamllint check for RST code listings.
felixfontein 1fdf7f9
Address review comments.
felixfontein eb5e659
Sort languages and remove no longer needed duplicates.
felixfontein bd53346
Enable warnings, but disable all failing rules.
felixfontein 8b698d4
Improve formulation.
felixfontein ed8baa1
Show allowed languages when no or invalid language is supplied. Impro…
felixfontein 8e25d90
Make sure that 'yamllint .' passes.
felixfontein 826e2a4
Fix indentation issues introduced in #2095.
felixfontein File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,8 @@ | ||
name: Ansible Docsite CI | ||
|
||
on: | ||
"on": | ||
schedule: | ||
# Daily | ||
# Daily | ||
- cron: "23 7 * * *" | ||
push: | ||
branches-ignore: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,68 @@ | ||
--- | ||
extends: default | ||
|
||
ignore: | ||
- /lib/ansible/ | ||
|
||
rules: | ||
line-length: disable | ||
# max: 160 | ||
# level: warning | ||
document-start: disable | ||
document-end: disable | ||
truthy: | ||
level: warning | ||
allowed-values: | ||
- 'true' | ||
- 'false' | ||
- 'True' | ||
- 'False' | ||
- 'TRUE' | ||
- 'FALSE' | ||
- 'yes' | ||
- 'no' | ||
- 'Yes' | ||
- 'No' | ||
- 'YES' | ||
- 'NO' | ||
indentation: disable | ||
# level: warning | ||
# spaces: 2 | ||
# indent-sequences: consistent | ||
key-duplicates: disable | ||
# level: warning | ||
# forbid-duplicated-merge-keys: true | ||
trailing-spaces: enable | ||
hyphens: disable | ||
# max-spaces-after: 1 | ||
# level: warning | ||
empty-lines: | ||
max: 2 | ||
max-start: 0 | ||
max-end: 0 | ||
level: warning | ||
commas: disable | ||
# max-spaces-before: 0 | ||
# min-spaces-after: 1 | ||
# max-spaces-after: 1 | ||
# level: warning | ||
colons: disable | ||
# max-spaces-before: 0 | ||
# max-spaces-after: 1 | ||
# level: warning | ||
brackets: disable | ||
# min-spaces-inside: 0 | ||
# max-spaces-inside: 0 | ||
# level: warning | ||
braces: | ||
min-spaces-inside: 0 | ||
max-spaces-inside: 1 | ||
level: warning | ||
octal-values: disable | ||
# forbid-implicit-octal: true | ||
# forbid-explicit-octal: true | ||
# level: warning | ||
comments: disable | ||
# min-spaces-from-content: 1 | ||
# level: warning | ||
comments-indentation: disable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
all: | ||
hosts: | ||
192.168.0.2 # Replace with the IP of your target host | ||
192.168.0.2 # Replace with the IP of your target host |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
{ | ||
"extensions": [ | ||
".rst", | ||
".txt" | ||
], | ||
"ignore_regexs": [ | ||
"^docs/docsite/rst/porting_guides/porting_guide_[0-9]+\\.rst$" | ||
] | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, dropping a config like https://github.com/ansible/awx-plugins/blob/e5f7468/.yamllint into the repo would allow these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally enabling
on
just for a handful of special YAML files sounds like a bad idea.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, there's an issue about this on the tracker.Apparently, there's an option to allow this just in YAML keys: adrienverge/yamllint#559 (comment). I'll probably go update my typical config...
UPD: the setting isn't actually there.