-
Notifications
You must be signed in to change notification settings - Fork 756
bulk update urls to insert the projects subdir #3260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Doh, yeah I shouldn't have touched the porting guides. ansible-community/ansible-build-data#627 should fix that. I'll update this. |
This change modifies url references to the community package docs on docs.ansible.com to include the Read the Docs projects subdirectory.
Thanks @felixfontein Should we update the older porting guides manually? Or should we do that through the |
|
Good question. I probably wouldn't modify them in ansible-build-data anymore since the releases are EOL. @gotmax23 @mariolenz WDYT? |
|
Yeah, I would probably avoid touching the EOL porting guides (I consider them historical documents) but don't feel super strongly. |
|
I wouldn't modify the porting guides in ansible-build-data for releases that are EOL. As @gotmax23 pointed out, they're kind of historical documents. Anyway, there might be even some more outdated links. Do we really want to go hunting for them and fix them? EOL means we don't touch this stuff anymore. Outdated and even broken links included IMHO. |
|
Thanks for the opinions on the old porting guides @gotmax23 and @mariolenz We'll leave them as-is with the old urls. They're harmless anyway since we have redirects in place. |
|
I'm going to go ahead and merge. Let's see how we get on with the backports. I might need to do them manually and separately look at each branch but maybe this commit will backport cleanly. Thanks for the reviews @felixfontein @gotmax23 @mariolenz |
Backport to stable-2.17: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 1da1e1d on top of patchback/backports/stable-2.17/1da1e1d77692fb71bdd4de6b22e0a3b7b8ae1e32/pr-3260 Backporting merged PR #3260 into devel
🤖 @patchback |
Backport to stable-2.18: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 1da1e1d on top of patchback/backports/stable-2.18/1da1e1d77692fb71bdd4de6b22e0a3b7b8ae1e32/pr-3260 Backporting merged PR #3260 into devel
🤖 @patchback |
Backport to stable-2.19: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 1da1e1d on top of patchback/backports/stable-2.19/1da1e1d77692fb71bdd4de6b22e0a3b7b8ae1e32/pr-3260 Backporting merged PR #3260 into devel
🤖 @patchback |
Backport to stable-2.20: 💚 backport PR created✅ Backport PR branch: Backported as #3275 🤖 @patchback |
This change modifies url references to the community package docs on docs.ansible.com to include the Read the Docs projects subdirectory. (cherry picked from commit 1da1e1d)
This change modifies url references to the community package docs on docs.ansible.com to include the Read the Docs projects subdirectory. (cherry picked from commit 1da1e1d) Co-authored-by: Don Naro <[email protected]>
This change modifies url references to the community package docs on docs.ansible.com to include the Read the Docs projects subdirectory.