Add details of interactions between notifications and loops #597

lod · 2023-10-12T23:05:17Z

This clarifies behaviour raised in ansible/ansible#81950 and ansible/ansible#77550 as expected and documented.

gotmax23

I left some initial feedback. Thanks for the contribution!

docs/docsite/rst/playbook_guide/playbooks_handlers.rst

gotmax23 · 2023-11-24T22:20:53Z

@lod, are you still interested in proceeding with this PR?

Co-authored-by: Maxwell G <[email protected]>

samccann · 2024-01-18T18:54:11Z

@gotmax23 - i committed your suggested edits. Can you take another look and approve the PR if you agree?

docs/docsite/rst/playbook_guide/playbooks_handlers.rst

oraNod · 2024-09-12T11:08:50Z

Hi @lod We've made some changes to the underlying readthedocs project for this repository. I'm going to close and re-open this issue to kick off a new PR preview build.

You might notice there will be two checks for readthedocs. One for docs/readthedocs.org:stage-ansible-core and another for docs/readthedocs.org:ansible-core.

The stage-ansible-core check is for the old project and will result in a 404. Please ignore that and use the ansible-core check only.

Thank you for your patience and understanding. Also thanks for your contribution to the Ansible documentation. If you have any questions or concerns, please do let us know either here, in the docs channel on Matrix, or in the Ansible forum. Cheers.

Make the loop trigger even more explicit.

lod · 2024-10-16T11:42:19Z

Thanks @felixfontein @samccann and @gotmax23

I incorporated the suggestions and resynced it against the current devel.

oraNod · 2024-10-24T08:49:06Z

Thanks for refreshing this PR and continuing with the changes @lod

oraNod

Thanks for the docs contribution @lod 🚀

patchback · 2024-10-25T09:39:04Z

Backport to stable-2.15: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.15/74b2c95dd4a13db21b167de9bb72f7287f679841/pr-597

Backported as #2063

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein

* Add details of interactions between notifications and loops This clarifies behaviour raised in ansible/ansible#81950 and ansible/ansible#77550 as expected and documented. * Apply suggestions from code review Co-authored-by: Maxwell G <[email protected]> * Incorporate suggestions from @felixfontein Make the loop trigger even more explicit. --------- Co-authored-by: Sandra McCann <[email protected]> Co-authored-by: Maxwell G <[email protected]> (cherry picked from commit 74b2c95)

patchback · 2024-10-25T09:39:27Z

Backport to stable-2.14: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.14/74b2c95dd4a13db21b167de9bb72f7287f679841/pr-597

Backported as #2064

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein

* Add details of interactions between notifications and loops This clarifies behaviour raised in ansible/ansible#81950 and ansible/ansible#77550 as expected and documented. * Apply suggestions from code review Co-authored-by: Maxwell G <[email protected]> * Incorporate suggestions from @felixfontein Make the loop trigger even more explicit. --------- Co-authored-by: Sandra McCann <[email protected]> Co-authored-by: Maxwell G <[email protected]> (cherry picked from commit 74b2c95)

patchback · 2024-10-25T09:39:50Z

Backport to stable-2.16: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.16/74b2c95dd4a13db21b167de9bb72f7287f679841/pr-597

Backported as #2065

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein

* Add details of interactions between notifications and loops This clarifies behaviour raised in ansible/ansible#81950 and ansible/ansible#77550 as expected and documented. * Apply suggestions from code review Co-authored-by: Maxwell G <[email protected]> * Incorporate suggestions from @felixfontein Make the loop trigger even more explicit. --------- Co-authored-by: Sandra McCann <[email protected]> Co-authored-by: Maxwell G <[email protected]> (cherry picked from commit 74b2c95)

patchback · 2024-10-25T09:40:14Z

Backport to stable-2.17: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.17/74b2c95dd4a13db21b167de9bb72f7287f679841/pr-597

Backported as #2066

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein

* Add details of interactions between notifications and loops This clarifies behaviour raised in ansible/ansible#81950 and ansible/ansible#77550 as expected and documented. * Apply suggestions from code review Co-authored-by: Maxwell G <[email protected]> * Incorporate suggestions from @felixfontein Make the loop trigger even more explicit. --------- Co-authored-by: Sandra McCann <[email protected]> Co-authored-by: Maxwell G <[email protected]> (cherry picked from commit 74b2c95)

patchback · 2024-10-25T09:40:37Z

Backport to stable-2.18: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.18/74b2c95dd4a13db21b167de9bb72f7287f679841/pr-597

Backported as #2067

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein

* Add details of interactions between notifications and loops This clarifies behaviour raised in ansible/ansible#81950 and ansible/ansible#77550 as expected and documented. * Apply suggestions from code review Co-authored-by: Maxwell G <[email protected]> * Incorporate suggestions from @felixfontein Make the loop trigger even more explicit. --------- Co-authored-by: Sandra McCann <[email protected]> Co-authored-by: Maxwell G <[email protected]> (cherry picked from commit 74b2c95)

@felixfontein

…2067) * Add details of interactions between notifications and loops This clarifies behaviour raised in ansible/ansible#81950 and ansible/ansible#77550 as expected and documented. * Apply suggestions from code review Co-authored-by: Maxwell G <[email protected]> * Incorporate suggestions from @felixfontein Make the loop trigger even more explicit. --------- Co-authored-by: Sandra McCann <[email protected]> Co-authored-by: Maxwell G <[email protected]> (cherry picked from commit 74b2c95) Co-authored-by: David Tulloh <[email protected]>

@felixfontein

…2065) * Add details of interactions between notifications and loops This clarifies behaviour raised in ansible/ansible#81950 and ansible/ansible#77550 as expected and documented. * Apply suggestions from code review Co-authored-by: Maxwell G <[email protected]> * Incorporate suggestions from @felixfontein Make the loop trigger even more explicit. --------- Co-authored-by: Sandra McCann <[email protected]> Co-authored-by: Maxwell G <[email protected]> (cherry picked from commit 74b2c95) Co-authored-by: David Tulloh <[email protected]>

@felixfontein

…2063) * Add details of interactions between notifications and loops This clarifies behaviour raised in ansible/ansible#81950 and ansible/ansible#77550 as expected and documented. * Apply suggestions from code review Co-authored-by: Maxwell G <[email protected]> * Incorporate suggestions from @felixfontein Make the loop trigger even more explicit. --------- Co-authored-by: Sandra McCann <[email protected]> Co-authored-by: Maxwell G <[email protected]> (cherry picked from commit 74b2c95) Co-authored-by: David Tulloh <[email protected]>

@felixfontein

…2064) * Add details of interactions between notifications and loops This clarifies behaviour raised in ansible/ansible#81950 and ansible/ansible#77550 as expected and documented. * Apply suggestions from code review Co-authored-by: Maxwell G <[email protected]> * Incorporate suggestions from @felixfontein Make the loop trigger even more explicit. --------- Co-authored-by: Sandra McCann <[email protected]> Co-authored-by: Maxwell G <[email protected]> (cherry picked from commit 74b2c95) Co-authored-by: David Tulloh <[email protected]>

@felixfontein

…2066) * Add details of interactions between notifications and loops This clarifies behaviour raised in ansible/ansible#81950 and ansible/ansible#77550 as expected and documented. * Apply suggestions from code review Co-authored-by: Maxwell G <[email protected]> * Incorporate suggestions from @felixfontein Make the loop trigger even more explicit. --------- Co-authored-by: Sandra McCann <[email protected]> Co-authored-by: Maxwell G <[email protected]> (cherry picked from commit 74b2c95) Co-authored-by: David Tulloh <[email protected]>

@felixfontein

* Add details of interactions between notifications and loops This clarifies behaviour raised in ansible/ansible#81950 and ansible/ansible#77550 as expected and documented. * Apply suggestions from code review Co-authored-by: Maxwell G <[email protected]> * Incorporate suggestions from @felixfontein Make the loop trigger even more explicit. --------- Co-authored-by: Sandra McCann <[email protected]> Co-authored-by: Maxwell G <[email protected]>

Add details of interactions between notifications and loops

4eca3ab

This clarifies behaviour raised in ansible/ansible#81950 and ansible/ansible#77550 as expected and documented.

github-actions bot added the needs_triage Needs a first human triage before being processed. label Oct 12, 2023

gotmax23 added the new_contributor This PR is the first contribution by a new community member. label Oct 13, 2023

gotmax23 reviewed Oct 13, 2023

View reviewed changes

docs/docsite/rst/playbook_guide/playbooks_handlers.rst Show resolved Hide resolved

docs/docsite/rst/playbook_guide/playbooks_handlers.rst Outdated Show resolved Hide resolved

docs/docsite/rst/playbook_guide/playbooks_handlers.rst Outdated Show resolved Hide resolved

gotmax23 added backport-2.15 labels Oct 13, 2023

gotmax23 added the needs_info requesting more detail from OP label Nov 24, 2023

Apply suggestions from code review

8eb4561

Co-authored-by: Maxwell G <[email protected]>

samccann temporarily deployed to github-bot January 18, 2024 18:53 — with GitHub Actions Inactive

samccann removed needs_info requesting more detail from OP needs_triage Needs a first human triage before being processed. labels Jan 18, 2024

felixfontein reviewed Feb 22, 2024

View reviewed changes

docs/docsite/rst/playbook_guide/playbooks_handlers.rst Show resolved Hide resolved

docs/docsite/rst/playbook_guide/playbooks_handlers.rst Show resolved Hide resolved

oraNod closed this Sep 12, 2024

oraNod reopened this Sep 12, 2024

oraNod temporarily deployed to github-bot September 12, 2024 11:08 — with GitHub Actions Inactive

Merge branch 'ansible:devel' into patch-1

a12ff54

lod temporarily deployed to github-bot October 16, 2024 10:52 — with GitHub Actions Inactive

Incorporate suggestions from @felixfontein

1b6123a

Make the loop trigger even more explicit.

lod temporarily deployed to github-bot October 16, 2024 11:40 — with GitHub Actions Inactive

oraNod requested review from felixfontein and gotmax23 October 24, 2024 08:48

oraNod added backport-2.17 Automatically create a backport for the stable-2.17 branch backport-2.18 Automatically create a backport for the stable-2.18 branch labels Oct 24, 2024

felixfontein approved these changes Oct 24, 2024

View reviewed changes

oraNod approved these changes Oct 25, 2024

View reviewed changes

oraNod merged commit 74b2c95 into ansible:devel Oct 25, 2024

patchback bot mentioned this pull request Oct 25, 2024

[PR #597/74b2c95d backport][stable-2.15] Add details of interactions between notifications and loops #2063

Merged

patchback bot mentioned this pull request Oct 25, 2024

[PR #597/74b2c95d backport][stable-2.14] Add details of interactions between notifications and loops #2064

Merged

patchback bot mentioned this pull request Oct 25, 2024

[PR #597/74b2c95d backport][stable-2.16] Add details of interactions between notifications and loops #2065

Merged

patchback bot mentioned this pull request Oct 25, 2024

[PR #597/74b2c95d backport][stable-2.17] Add details of interactions between notifications and loops #2066

Merged

patchback bot mentioned this pull request Oct 25, 2024

[PR #597/74b2c95d backport][stable-2.18] Add details of interactions between notifications and loops #2067

Merged

Add details of interactions between notifications and loops #597

Add details of interactions between notifications and loops #597

Uh oh!

Conversation

lod commented Oct 12, 2023

Uh oh!

gotmax23 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gotmax23 commented Nov 24, 2023

Uh oh!

samccann commented Jan 18, 2024

Uh oh!

Uh oh!

Uh oh!

oraNod commented Sep 12, 2024

Uh oh!

lod commented Oct 16, 2024

Uh oh!

oraNod commented Oct 24, 2024

Uh oh!

oraNod left a comment

Choose a reason for hiding this comment

Uh oh!

patchback bot commented Oct 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Backport to stable-2.15: 💚 backport PR created

Uh oh!

patchback bot commented Oct 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Backport to stable-2.14: 💚 backport PR created

Uh oh!

patchback bot commented Oct 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Backport to stable-2.16: 💚 backport PR created

Uh oh!

patchback bot commented Oct 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Backport to stable-2.17: 💚 backport PR created

Uh oh!

patchback bot commented Oct 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Backport to stable-2.18: 💚 backport PR created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

patchback bot commented Oct 25, 2024 •

edited

Loading

patchback bot commented Oct 25, 2024 •

edited

Loading

patchback bot commented Oct 25, 2024 •

edited

Loading

patchback bot commented Oct 25, 2024 •

edited

Loading

patchback bot commented Oct 25, 2024 •

edited

Loading