Skip to content

chore: use reusable tox workflow #2057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

chore: use reusable tox workflow #2057

wants to merge 2 commits into from

Conversation

@ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Oct 7, 2025

No description provided.

@ssbarnea ssbarnea requested a review from a team as a code owner October 7, 2025 15:19
@ssbarnea ssbarnea enabled auto-merge (squash) October 7, 2025 15:19
@github-actions github-actions bot added the chore Maintenance tasks, not affecting shipped product label Oct 7, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 7, 2025
View reviewed changes
.github/workflows/tox.yml
Comment on lines +25 to +35
uses: ansible/team-devtools/.github/workflows/tox.yml@main
secrets: inherit
with:
min_python: "3.10"
default_python: "3.13"
max_python: "3.13"
other_names: |
pkg
lint
docs
py314-devel

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}

Copilot Autofix

AI about 2 months ago

To fix the problem, insert a permissions: section at the root of the workflow, immediately after the name: (and before on:), limiting the permissions of the GITHUB_TOKEN to the minimum needed. Since this workflow delegates the actual job to a remote workflow, it is safest to set a minimal default here, such as contents: read. If more specific write privileges are needed, they should be added as required. In this case, adding permissions: contents: read at the start of the workflow should mitigate the risk and adhere to CodeQL's recommendation.

Suggested changeset 1
.github/workflows/tox.yml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/tox.yml b/.github/workflows/tox.yml
--- a/.github/workflows/tox.yml
+++ b/.github/workflows/tox.yml
@@ -1,4 +1,6 @@
 name: tox
+permissions:
+  contents: read
 
 on:
   create: # is used for publishing to PyPI and TestPyPI
EOF
@@ -1,4 +1,6 @@
name: tox
permissions:
contents: read

on:
create: # is used for publishing to PyPI and TestPyPI
Copilot is powered by AI and may make mistakes. Always verify output.
@alisonlhart
Copy link
Collaborator

alisonlhart commented Oct 7, 2025

Moving to draft due to CI failures.

@alisonlhart alisonlhart marked this pull request as draft October 7, 2025 23:55
auto-merge was automatically disabled October 7, 2025 23:55

Pull request was converted to draft

@github-actions github-actions bot added chore Maintenance tasks, not affecting shipped product and removed chore Maintenance tasks, not affecting shipped product labels Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

chore Maintenance tasks, not affecting shipped product

Projects

🧰 devtools project board
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ssbarnea @alisonlhart