Skip to content

AAP-60075 - Add logging#172

Merged
kcagran merged 2 commits intomainfrom
logs
Dec 16, 2025
Merged

AAP-60075 - Add logging#172
kcagran merged 2 commits intomainfrom
logs

Conversation

@kcagran
Copy link
Contributor

@kcagran kcagran commented Dec 3, 2025

This pull request introduces enhanced logging throughout the authentication and user management modules, and adds the django-guid dependency to the project. The logging changes improve traceability and debugging by providing more detailed, context-specific log messages, while the dependency update ensures compatibility with packages requiring django-guid.

Dependency updates:

  • Added django-guid==3.5.2 to both requirements-build.txt and requirements-pinned.txt, including hash values and references in comments. This supports packages that depend on django-guid. [1] [2] [3] [4]

Logging improvements:

  • Replaced generic logger names in src/backend/apps/aap_auth/aap_auth.py, authentication.py, jwt_token.py, and connector.py with more specific ones, and added detailed log messages at key points in authentication, token handling, and connector operations. This includes info, debug, warning, and error logs to facilitate debugging and monitoring. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]

Code organization:

  • Minor import reordering and grouping in src/backend/apps/clusters/connector.py for improved readability and consistency.

These changes collectively improve maintainability, observability, and compatibility of the authentication and cluster connector components.

@kcagran kcagran requested a review from cshiels-ie December 3, 2025 07:07
@kcagran kcagran self-assigned this Dec 3, 2025
@github-actions
Copy link

github-actions bot commented Dec 3, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
6600 5042 76% 0% 🟢

New Files

File Coverage Status
src/backend/constants.py 100% 🟢
src/backend/utils/filters.py 82% 🟢
TOTAL 91% 🟢

Modified Files

File Coverage Status
src/backend/apps/aap_auth/aap_auth.py 59% 🟢
src/backend/apps/aap_auth/authentication.py 46% 🟢
src/backend/apps/aap_auth/jwt_token.py 95% 🟢
src/backend/apps/clusters/connector.py 87% 🟢
src/backend/apps/clusters/encryption.py 93% 🟢
src/backend/apps/clusters/parser.py 82% 🟢
src/backend/django_config/settings.py 91% 🟢
src/backend/tests/settings_for_test.py 100% 🟢
TOTAL 82% 🟢

updated for commit: c2b8fa9 by action🐍

@SherinV SherinV changed the title AAP-58986 - Add logging AAP-60075 - Add logging Dec 4, 2025
@SherinV
Copy link
Contributor

SherinV commented Dec 4, 2025

Parent ticket is AAP-58065

@kcagran kcagran requested a review from pmflanagan December 16, 2025 11:31
Copy link
Contributor

@pmflanagan pmflanagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kcagran kcagran merged commit 1f1898d into main Dec 16, 2025
8 checks passed
@kcagran kcagran deleted the logs branch December 16, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants