Conversation
….6-1 just cp from .tar.gz Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
It often fails when combined with daemon_reload Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Before: everyone was using same hardcoded SECRED_KEY Enduser will need to run 'python manage.py setclusters clusters.yaml' again. Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Application requires redis since ffe1def. PR adds redis to deployment.
PR also:
The last point means, all existing customers will need to run
manage.py setclusters clusters.yamlafter upgrade, because old values in database will not be accessible after SECRET_KEY is replaced. Since they need to add new fields toclusters.yaml, they need to run this command after upgrade anyway.