Merged
Conversation
Partially fixes AAP-62273 Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
task container started via systemd did receive SIGTERM, but workers did not receive it, and were force killed. Updating dispatcherd helped. Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
log_level is not a valid in metrics_kwargs Tested with tests/mock_aap/test_full.py from #209 Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
justinc1
force-pushed
the
AAP-62273-longer-stop-timeout-for-task
branch
from
8656ff9 to
ec941e7
Compare
|
Requirements-build.txt needs to be updated The |
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
justinc1
force-pushed
the
AAP-62273-longer-stop-timeout-for-task
branch
from
ec941e7 to
17f6e16
Compare
|
cshiels-ie
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running
systemctl --user stop automation-dashboard-task, we get in logsERROR:dispatcherd.service.pool:Worker 1 pid=70 failed to send exit message in 3 seconds. The worker is then killed, potentionaly in middle of work.PR updates dispatcherd, and this helps. In logs I see
2026-01-29 17:27:29,727 WARNING [-] dispatcherd.worker.target Worker 1 exiting main loop due to stop message.The 60 seconds timeout in systemd is just additional safeguard. I assume worker could be in middle of slow http GET, and might need extra time.
PR removes one setting from dispatcherd
config.py. This gave a nice oportunity to check if additional tests in #209 catch this bad code - the did show the problem (without building image, building bundled installer, deploying to a VM, etc).