Add packaging dependency for indirect node counting#270
Draft
fosterseth wants to merge 1 commit intodevelfrom
Draft
Add packaging dependency for indirect node counting#270fosterseth wants to merge 1 commit intodevelfrom
fosterseth wants to merge 1 commit intodevelfrom
Conversation
The indirect_instance_count callback plugin requires the packaging library for semantic version comparison in the external query version fallback logic (AAP-58452). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
djyasin
approved these changes
Feb 27, 2026
Member
Author
|
i'm not so sure this is needed, don't merge it yet |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
packagingto the EE's Python dependencies.The
indirect_instance_countcallback plugin (which runs inside the EE) importspackaging.versionfor semantic version comparison in the external query version fallback logic (AAP-58452). Without this dependency, the callback plugin fails to load, breaking all indirect node counting — including the existing embedded query path.Related: ansible/awx#16312