Skip to content

Add test to ensure bootstrap reqs are good#15733

Merged
AlanCoding merged 3 commits intoansible:develfrom
AlanCoding:bootstrap_test
Jan 13, 2025
Merged

Add test to ensure bootstrap reqs are good#15733
AlanCoding merged 3 commits intoansible:develfrom
AlanCoding:bootstrap_test

Conversation

@AlanCoding
Copy link
Member

SUMMARY

Adds a regression test for what #15732 by @saito-hideki fixes

It should fail until that is merged.

This test is intended to be "lazy" and brutal in implementation. As you can see in this file, importing from libs like pip is fragile and tends to break. This should continue to work as long as we keep our file structures the same, and if someone changes it, then can come edit this test.

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • API

@AlanCoding
Copy link
Member Author

expected failure:

AssertionError: assert 'setuptools==69.0.2' == 'setuptools==75.6.0'
  
  - setuptools==75.6.0
  ?             ---
  + setuptools==69.0.2
  ?              +  ++
===============================

maybe I can do better. Might push another commit.

@AlanCoding
Copy link
Member Author

I like this now

  File "/awx_devel/awx/main/tests/functional/test_python_requirements.py", line 35, in test_bootstrap_consistent
    assert not different_requirements
AssertionError: assert not [('pip==21.2.4', 'pip==21.2.4'), ('setuptools==69.0.2', 'setuptools==75.6.0'), ('wheel==0.42.0', 'wheel==0.45.1'), ('cython==0.29.37', 'cython==3.0.11')]

@AlanCoding AlanCoding marked this pull request as ready for review January 13, 2025 18:48
@AlanCoding
Copy link
Member Author

The test result kept me honest here, I had an error and it was failing. But it should be good now. Will revisit again and hopefully merge when it passes.

@sonarqubecloud
Copy link

@AlanCoding AlanCoding merged commit fb12c83 into ansible:devel Jan 13, 2025
23 of 25 checks passed
@codecov
Copy link

codecov bot commented Apr 13, 2025

Codecov Report

Attention: Patch coverage is 84.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 75.24%. Comparing base (6228fe9) to head (e9e124a).
Report is 95 commits behind head on devel.

✅ All tests successful. No failed tests found.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants