Skip to content

Add client_secret and client_id to credential_input_fields#15734

Merged
djyasin merged 1 commit intoansible:develfrom
djyasin:AAP-37213_awxkit_add_service_account_support_for_Insights_credential_type
Jan 15, 2025
Merged

Add client_secret and client_id to credential_input_fields#15734
djyasin merged 1 commit intoansible:develfrom
djyasin:AAP-37213_awxkit_add_service_account_support_for_Insights_credential_type

Conversation

@djyasin
Copy link
Member

@djyasin djyasin commented Jan 9, 2025

SUMMARY

Related to ansible/awx-plugins#71
awxkit - add service account support for Insights credential type, specifically adding the fields client_id and client_secret to credential_input_fields

ISSUE TYPE
  • New or Enhanced Feature
COMPONENT NAME
  • API
AWX VERSION
24.6.2
ADDITIONAL INFORMATION

To test changes, use the following command:
awx --conf.host <path to your awx host> --conf.username <username> --conf.password <password> --conf.insecure credential create --name <name of credential> --credential_type 14 --user <user ID> --inputs '{"client_id": "foo", "client_secret": "bar"}'

credential_type 14 is the insights credential.


@djyasin djyasin force-pushed the AAP-37213_awxkit_add_service_account_support_for_Insights_credential_type branch 3 times, most recently from 4742457 to 40500a7 Compare January 13, 2025 18:17
@djyasin djyasin marked this pull request as ready for review January 13, 2025 18:17
@djyasin djyasin changed the title [DRAFT] Add client_secret and client_id to credential_input_fields Add client_secret and client_id to credential_input_fields Jan 13, 2025
@djyasin djyasin force-pushed the AAP-37213_awxkit_add_service_account_support_for_Insights_credential_type branch from 40500a7 to fc2e3c0 Compare January 14, 2025 19:15
@sonarqubecloud
Copy link

@djyasin djyasin requested a review from fosterseth January 14, 2025 20:53
Copy link
Member

@fosterseth fosterseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

@djyasin djyasin merged commit 211339c into ansible:devel Jan 15, 2025
26 checks passed
@codecov
Copy link

codecov bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.25%. Comparing base (f89be5e) to head (fc2e3c0).
Report is 93 commits behind head on devel.

✅ All tests successful. No failed tests found.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants