Skip to content

Fix dependency upgrades#15740

Merged
AlanCoding merged 6 commits intoansible:develfrom
AlanCoding:fix_dep_update_test_alan
Jan 10, 2025
Merged

Fix dependency upgrades#15740
AlanCoding merged 6 commits intoansible:develfrom
AlanCoding:fix_dep_update_test_alan

Conversation

@AlanCoding
Copy link
Member

@AlanCoding AlanCoding commented Jan 10, 2025

SUMMARY

This includes

just want to put this up to document

For people visiting from the future, pypa/setuptools#4457 is the setuptools PR that causes the pin added here. It modifies sys.path and this causes import errors, because the irc lib has dependencies overlapping with setuptools _vendor directory, and they conflict, functionally.

Next pallets/markupsafe#478 put a minimum pin on setuptools, but this is non-conflicting with our other needs because there is a version range that satisfies markupsafe's new requirement while still pre-dating the sys.path hack.

I don't have a particularly good reference for the cryptography situation, other than general release notes, which make a ton of notes about specific OpenSSL versions.

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • API

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Jan 10, 2025
@AlanCoding AlanCoding changed the title Fix dep update test alan Fix dependency upgrades Jan 10, 2025
@AlanCoding AlanCoding marked this pull request as ready for review January 10, 2025 20:58
@sonarqubecloud
Copy link

@AlanCoding AlanCoding enabled auto-merge (squash) January 10, 2025 21:11
@AlanCoding AlanCoding merged commit c1572af into ansible:devel Jan 10, 2025
19 checks passed
@codecov
Copy link

codecov bot commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.25%. Comparing base (5607961) to head (8774268).
Report is 97 commits behind head on devel.

✅ All tests successful. No failed tests found.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants