Skip to content

Conversation

AlanCoding
Copy link
Member

@AlanCoding AlanCoding commented Sep 5, 2025

Description

Fixes #159

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Test update
  • Refactoring (no functional changes)
  • Development environment change
  • Configuration change

Self-Review Checklist

  • I have performed a self-review of my code
  • I have added relevant comments to complex code sections
  • I have updated documentation where needed
  • I have considered the security impact of these changes
  • I have considered performance implications
  • I have thought about error handling and edge cases
  • I have tested the changes in my local environment

Note

Removes the tracked-relationship syncing feature and associated model fields, signals, docs, and tests.

  • RBAC Core:
    • Remove tracked-relationship syncing infrastructure:
      • Delete PermissionRegistry tracking (_tracked_relationships, _trackers, track_relationship, init wiring).
      • Remove TrackedRelationship class and signal handlers in ansible_base/rbac/triggers.py.
      • Drop tracker-sync calls from RoleDefinition.give_or_remove_permission.
  • Models & Migrations (test_app):
    • Remove relationship fields: Organization.users, Organization.admins, Team.users, Team.admins, Team.team_parents (and adjust 0001_initial.py, 0006_team_admins_team_users.py).
    • Update test_app/models.py to drop corresponding fields and permission_registry.track_relationship(...) calls.
  • Docs:
    • Remove the "Tracked Relationships" section from docs/apps/rbac/for_app_developers.md.
  • Tests:
    • Delete relationship-tracking tests (test_role_tracking.py) and related API/tests relying on those relationships.
    • Remove M2M-related ignore test in test_common.py; minor fixture doc tweaks.

Written by Cursor Bugbot for commit ad7001f. This will update automatically on new commits. Configure here.

@AlanCoding AlanCoding marked this pull request as ready for review September 5, 2025 15:37
cursor[bot]

This comment was marked as outdated.

Copy link

github-actions bot commented Oct 6, 2025

DVCS PR Check Results:

PR appears valid (JIRA key(s) found)

Copy link

sonarqubecloud bot commented Oct 6, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RBAC] Remove the "relationship tracking" or "role tracking" feature
1 participant