Skip to content

Make role assignment sync logging more descriptive #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from
Open

Make role assignment sync logging more descriptive #828

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc815d4
make role assignment sync logging more descriptive
jessicamack Sep 8, 2025
abafc5f
fix f-string with line break
jessicamack Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 27 additions & 15 deletions ansible_base/resource_registry/tasks/sync.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -705,38 +705,50 @@ def _sync_assignments(self):
to_delete = local_assignments - remote_assignments
to_create = remote_assignments - local_assignments

deleted_count = 0
created_count = 0
error_count = 0
deleted_assignments = []
created_assigments = []
errored_assignments = []

# Delete local assignments that don't exist remotely
for assignment_tuple in to_delete:
if delete_local_assignment(assignment_tuple):
deleted_count += 1
self.write(
delete_msg = (
f"DELETED assignment {assignment_tuple.assignment_type} {assignment_tuple.actor_ansible_id}"
" -> {assignment_tuple.role_definition_name} on {assignment_tuple.ansible_id_or_pk or 'global'}"
f" -> {assignment_tuple.role_definition_name} on {assignment_tuple.ansible_id_or_pk or 'global'}"
)
self.write(delete_msg)
self.results["deleted_assignments"].append(delete_msg)
else:
error_count += 1
error_msg = (
f"ERRORED while DELETING assignment {assignment_tuple.assignment_type} {assignment_tuple.actor_ansible_id}"
f" -> {assignment_tuple.role_definition_name} on {assignment_tuple.ansible_id_or_pk or 'global'}"
)
self.write(error_msg)
self.results["errored_assignments"].append(error_msg)

# Create local assignments that exist remotely but not locally
for assignment_tuple in to_create:
if create_local_assignment(assignment_tuple):
created_count += 1
self.write(
created_msg = (
f"CREATED assignment {assignment_tuple.assignment_type} {assignment_tuple.actor_ansible_id}"
" -> {assignment_tuple.role_definition_name} on {assignment_tuple.ansible_id_or_pk or 'global'}"
f" -> {assignment_tuple.role_definition_name} on {assignment_tuple.ansible_id_or_pk or 'global'}"
)
self.write(created_msg)
self.results["created_assigments"].append(created_msg)
else:
error_count += 1
error_msg = (
f"ERRORED while CREATING assignment {assignment_tuple.assignment_type} {assignment_tuple.actor_ansible_id}"
f" -> {assignment_tuple.role_definition_name} on {assignment_tuple.ansible_id_or_pk or 'global'}"
)
self.write(error_msg)
self.results["errored_assignments"].append(error_msg)

self.write(f"Assignment sync completed: Created {created_count} | Deleted {deleted_count} | Errors {error_count}")
self.write(f"Assignment sync completed: Created {len(created_assigments)} | Deleted {len(deleted_assignments)} | Errors {len(errored_assignments)}")

# Store results for reporting
self.results["assignments_created"] = [created_count]
self.results["assignments_deleted"] = [deleted_count]
self.results["assignment_errors"] = [error_count]
self.results["assignments_created"] = created_assigments
self.results["assignments_deleted"] = deleted_assignments
self.results["assignment_errors"] = errored_assignments

except Exception as e:
self.write(f"Assignment sync failed: {e}")
Expand Down
Loading