Skip to content

AAP-45047 fix authentication map conditional check #847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from
Open

AAP-45047 fix authentication map conditional check #847

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions ansible_base/authentication/utils/claims.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,10 +120,11 @@ def create_claims(authenticator: Authenticator, username: str, attrs: dict, grou
rule_responses.append({mpk: has_permission, 'enabled': auth_map.enabled})

understood_map = False
if auth_map.map_type == 'allow' and not has_permission:
# If any rule does not allow we don't want to return this to true
access_allowed = False
understood_map = True
if auth_map.map_type == 'allow':
if not has_permission:
# If any rule does not allow we don't want to return this to true
access_allowed = False
understood_map = True
elif auth_map.map_type == 'is_superuser':
is_superuser = has_permission
understood_map = True
Expand Down
Loading