AAP-51352 Change metric used to determine if pytest is being used #858
+20
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What I did in #853 turned out to have a critical flaw, revealed in ansible/awx#16114
Basically, pytest automatically sets
settings.DEBUG
to False and this is accepted standard practice.After doing some more research, these environment variables are relatively standard and reliable. Supposedly it still might not be picked up in fixtures, but I have never observed that.
Type of Change
Note
Introduce
is_testing()
(env-based pytest detection) and use it inServiceID
creation logic; add corresponding test.is_testing()
inansible_base/lib/utils/settings.py
usingPYTEST_CURRENT_TEST
/PYTEST_XDIST_WORKER
env vars.service_identifier.service_id()
to useis_testing()
instead of checkingsys.argv
for pytest.test_is_testing
and importis_testing
intest_settings.py
.Written by Cursor Bugbot for commit 3760236. This will update automatically on new commits. Configure here.