chore: make debug setting true for tests (#884)

Author: AlanCoding

tests/integration/api/test_fallback_handler.py

@@ -1,6 +1,7 @@
 from unittest import mock
 
 import pytest
+from django.test import override_settings
 from rest_framework import status
 from rest_framework.test import APIClient
 
@@ -20,19 +21,19 @@ def raise_exception(self, request):
     "aap_eda.api.views.project.ProjectViewSet.list", new=raise_exception
 )
 def test_debug_unexpected_exception(admin_client: APIClient, settings):
-    settings.DEBUG = True
-    with pytest.raises(FallbackException):
-        admin_client.get(f"{api_url_v1}/projects/")
+    with override_settings(DEBUG=True):
+        with pytest.raises(FallbackException):
+            admin_client.get(f"{api_url_v1}/projects/")
 
 
 @pytest.mark.django_db
 @mock.patch(
     "aap_eda.api.views.project.ProjectViewSet.list", new=raise_exception
 )
 def test_non_debug_unexpected_exception(admin_client: APIClient, settings):
-    settings.DEBUG = False
-    response = admin_client.get(f"{api_url_v1}/projects/")
-    assert response.status_code == status.HTTP_500_INTERNAL_SERVER_ERROR
+    with override_settings(DEBUG=False):
+        response = admin_client.get(f"{api_url_v1}/projects/")
+        assert response.status_code == status.HTTP_500_INTERNAL_SERVER_ERROR
 
-    data = response.json()
-    assert data["detail"].startswith("Unexpected server error")
+        data = response.json()
+        assert data["detail"].startswith("Unexpected server error")

tests/integration/conftest.py

@@ -23,6 +23,7 @@
 from ansible_base.rbac.models import DABPermission, RoleDefinition
 from django.conf import settings
 from django.contrib.contenttypes.models import ContentType
+from django.test import override_settings
 from rest_framework.test import APIClient
 
 from aap_eda.core import enums, models
@@ -770,6 +771,13 @@ def default_activation_instance_logs(
 """
 
 
+@pytest.fixture(autouse=True)
+def use_debug_setting():
+    with override_settings(DEBUG=True):
+        yield
+
+
+# fixture for a running redis server
 @pytest.fixture
 def default_credential_type() -> models.CredentialType:
     """Return a default Credential Type."""

tests/integration/dab_rbac/test_crud_permissions.py

@@ -16,7 +16,6 @@
 from ansible_base.rbac import permission_registry
 from ansible_base.rbac.models import DABPermission, RoleDefinition
 from django.contrib.contenttypes.models import ContentType
-from django.test import override_settings
 from django.urls.exceptions import NoReverseMatch
 from rest_framework.reverse import reverse
 
@@ -39,7 +38,6 @@ def get_detail_url(obj, skip_if_not_found=False):
         raise
 
 
-@override_settings(DEBUG=True)
 @pytest.mark.django_db
 @pytest.mark.parametrize("model", permission_registry.all_registered_models)
 def test_add_permissions(
@@ -125,7 +123,6 @@ def test_add_permissions(
     assert default_user.has_obj_perm(obj, "view")
 
 
-@override_settings(DEBUG=True)
 @pytest.mark.django_db
 @pytest.mark.parametrize("model", permission_registry.all_registered_models)
 def test_view_permissions(
@@ -147,7 +144,6 @@ def test_view_permissions(
     assert response.status_code == 200, response.data
 
 
-@override_settings(DEBUG=True)
 @pytest.mark.django_db
 @pytest.mark.parametrize("model", permission_registry.all_registered_models)
 def test_change_permissions(

tests/integration/dab_rbac/test_organization.py

@@ -15,7 +15,6 @@
 import pytest
 from django.apps import apps
 from django.core.exceptions import FieldDoesNotExist
-from django.test import override_settings
 from django.urls.exceptions import NoReverseMatch
 from rest_framework.reverse import reverse
 
@@ -35,7 +34,6 @@ def has_field(cls, field_name):
 ]
 
 
-@override_settings(DEBUG=True)
 @pytest.mark.django_db
 @pytest.mark.parametrize("model", ORG_MODELS)
 def test_create_with_default_org(cls_factory, model, admin_client, request):
@@ -72,7 +70,6 @@ def test_create_with_default_org(cls_factory, model, admin_client, request):
     assert obj.organization.name == "Default"
 
 
-@override_settings(DEBUG=True)
 @pytest.mark.django_db
 @pytest.mark.parametrize("model", ORG_MODELS)
 def test_create_with_custom_org(

tests/integration/test_sanity.py

@@ -0,0 +1,5 @@
+from django.conf import settings
+
+
+def test_debug_enabled_for_testing():
+    assert settings.DEBUG is True