fix: log stack trace only at DEBUG mode (#877)

Author: bzwei

src/aap_eda/services/activation/activation_manager.py

@@ -1017,7 +1017,7 @@ def _get_container_request(self) -> ContainerRequest:
                 f"Activation {self.db_instance.id} not valid, "
                 "container request cannot be built."
             )
-            LOGGER.exception(msg)
+            LOGGER.error(msg, exc_info=settings.DEBUG)
             raise exceptions.ActivationManagerError(msg)
 
     def check_new_process_allowed(self) -> bool:

src/aap_eda/services/activation/engine/podman.py

@@ -332,7 +332,7 @@ def _login(self, request: ContainerRequest) -> None:
                 f"{credential.username} login succeeded to {registry}"
             )
         except APIError as e:
-            LOGGER.exception("Login failed: f{e}")
+            LOGGER.error("Login failed: f{e}", exc_info=settings.DEBUG)
             raise exceptions.ContainerStartError(str(e))
 
     def _pull_image(

src/aap_eda/services/project/imports.py

@@ -21,6 +21,7 @@
 from typing import Any, Callable, Final, Iterator, Optional, Type
 
 import yaml
+from django.conf import settings
 from django.core import exceptions
 
 from aap_eda.core import models
@@ -225,10 +226,11 @@ def _find_rulebooks(self, repo: StrPath) -> Iterator[RulebookInfo]:
                 try:
                     info = self._try_load_rulebook(rulebooks_dir, path)
                 except Exception:
-                    logger.exception(
+                    logger.error(
                         "Unexpected exception when scanning file %s."
                         " Skipping.",
                         path,
+                        exc_info=settings.DEBUG,
                     )
                     continue
                 if not info:

src/aap_eda/tasks/orchestrator.py

@@ -143,9 +143,10 @@ def _run_request(
     except exceptions.MaxRunningProcessesError:
         return False
     except Exception as e:
-        LOGGER.exception(
+        LOGGER.error(
             f"Failed to process request {request.request} for "
             f"{process_parent_type} {process_parent.id}. Reason {str(e)}",
+            exc_info=settings.DEBUG,
         )
     return True
 

src/aap_eda/tasks/project.py

@@ -14,6 +14,8 @@
 
 import logging
 
+from django.conf import settings
+
 from aap_eda.core import models
 from aap_eda.core.tasking import get_queue, job, unique_enqueue
 from aap_eda.services.project import ProjectImportError, ProjectImportService
@@ -30,7 +32,7 @@ def import_project(project_id: int):
     try:
         ProjectImportService().import_project(project)
     except ProjectImportError as e:
-        logger.exception(e)
+        logger.error(e, exc_info=settings.DEBUG)
 
     logger.info(f"Task complete: Import project ( project_id={project.id} )")
 
@@ -43,7 +45,7 @@ def sync_project(project_id: int):
     try:
         ProjectImportService().sync_project(project)
     except ProjectImportError as e:
-        logger.exception(e)
+        logger.error(e, exc_info=settings.DEBUG)
 
     logger.info(f"Task complete: Sync project ( project_id={project.id} )")