Skip to content

Conversation

Alex-Izquierdo
Copy link
Collaborator

@Alex-Izquierdo Alex-Izquierdo commented Sep 22, 2025

Implement a force flag for all the operations for an activation that needs container cleanup when the activation is in workers_offline state.
It includes:

  • Enable force flag for RESTART, DISABLE and DELETE activation when the status is workers_offline
  • Encapsulate logic into a method
  • Update error message
  • Update tests accordingly.

This PR wants to leave prepared the implementation ready for the counterpart needed at the UI (jira: https://issues.redhat.com/browse/AAP-52714)

Jira: https://issues.redhat.com/browse/AAP-51378

@Alex-Izquierdo Alex-Izquierdo force-pushed the force-flag-delete-disable branch 2 times, most recently from ab1fb5f to d66bae9 Compare September 22, 2025 13:54
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.36%. Comparing base (7813e2f) to head (8d0deee).

@@           Coverage Diff           @@
##             main    #1397   +/-   ##
=======================================
  Coverage   94.35%   94.36%           
=======================================
  Files         339      339           
  Lines       19983    20003   +20     
=======================================
+ Hits        18855    18875   +20     
  Misses       1128     1128           
Flag Coverage Δ
unit-int-tests-3.11 94.30% <100.00%> (+<0.01%) ⬆️
unit-int-tests-3.12 94.36% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/aap_eda/api/views/activation.py 97.20% <100.00%> (+0.05%) ⬆️
tests/integration/api/test_activation.py 98.83% <100.00%> (+0.03%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants