fix: [AAP-64560] Add comprehensive dispatcherd health checks #1460
Conversation
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #1460 +/- ##
==========================================
- Coverage 91.45% 91.43% -0.03%
==========================================
Files 234 235 +1
Lines 10089 10122 +33
==========================================
+ Hits 9227 9255 +28
- Misses 862 867 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
|
The multinode tests failures passed in https://github.com/ansible/eda-server/actions/runs/21753743749 |
AlanCoding
left a comment
AlanCoding
left a comment
There was a problem hiding this comment.
Looks well-designed, and actually very small in terms of the code practice change.
There was already a health-checking method, and looks good to continue expanding that out in the code patterns you have here.
Answering the review question I was going to ask - this appears to try to make the checks targeted, as for project update, it only checks the default workers, but activations legitimately require both default & activation workers to process tasks
Yes, projects only needs default workers, but activations need both default & activation workers |
- Add ActivationWorkerUnavailable exception for activation worker health - Implement check_dispatcherd_health() function for worker availability - Integrate health checks into activation create/enable operations - Add comprehensive test coverage for health check functionality - Update all activation tests with proper health check mocking Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
|
4 participants
https://issues.redhat.com/browse/AAP-64560