feat: allow for dedicated event streams database user #1468
+106
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkanoor
reviewed
Feb 9, 2026
| credential_type = models.CredentialType.objects.get( | ||
| name=enums.DefaultCredentialType.POSTGRES | ||
| ) | ||
| for field in credential_type.inputs.get("fields", []): |
Contributor
There was a problem hiding this comment.
@ttuffin should we save/update this only if we are missing the type so its just done once and use the new schema which has the type and maybe other changes down the road.
Contributor
Author
There was a problem hiding this comment.
@mkanoor I've updated the logic to check if there is any mismatch with the schema, and if so, reapply the entire schema.
ttuffin
force-pushed
the
AAP-64874_pgnotify_creds
branch
from
f614283 to
e770be4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1468 +/- ##
==========================================
+ Coverage 91.45% 91.46% +0.01%
==========================================
Files 234 234
Lines 10089 10102 +13
==========================================
+ Hits 9227 9240 +13
Misses 862 862
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
ttuffin
force-pushed
the
AAP-64874_pgnotify_creds
branch
2 times, most recently
from
8deb9f5 to
836abfe
Compare
Contributor
Author
|
Added unit tests. |
ttuffin
force-pushed
the
AAP-64874_pgnotify_creds
branch
from
836abfe to
e68d997
Compare
- Fix postrgres credential type but adding the 'type' field - Allow for setting a specific event stream database user
ttuffin
force-pushed
the
AAP-64874_pgnotify_creds
branch
from
e68d997 to
ccbf22d
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows for the definition of a dedicated database user account specifically for event streams. If
EVENT_STREAM_DB_USERandEVENT_STREAM_DB_PASSWORDare defined, those credentials will be used by both the event stream (producer) and the activation (consumer). If either of these settings are undefined the default database credentials will be used.https://issues.redhat.com/browse/AAP-64874