library.dataframes.BaseTraditional - move merge logic to child classes #313
+145
−87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge was a shared method, calling summarize_merged_dataframes & cast_datafame, also shared, both called with details from per-class unique_index_columns, data_columns & cast_types the abstraction makes sense, but we can remove a lot of extra complexity with it, leaving the 3 dataframes that need it a bit more readable
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the library traditional dataframes to move the full merge logic into a method in each of the 3 classes.
mergewas a shared method, callingsummarize_merged_dataframes&cast_datafame, also shared, both called with details from per-classunique_index_columns,data_columns&cast_typesthe abstraction makes sense, but we can remove extra complexity with it, and the result is a simple set of pandas instructions.
(Also drops the logic casting all indexes to objects.)
wip - test with #285