Skip to content

fix: display errors when schema validation fails #4623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
chronicc wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Draft

fix: display errors when schema validation fails #4623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .config/dictionary.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ passwordless
prepender
prerun
profisioner
psql
pycolors
reget
resetall
Expand Down
3 changes: 2 additions & 1 deletion src/molecule/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -751,7 +751,8 @@ def _validate(self) -> None:

errors = schema_v3.validate(self.config)
if errors:
msg = f"Failed to validate {self.molecule_file}\n\n{errors}"
errors_resolved = "\n".join(errors)
msg = f"Failed to validate {self.molecule_file}\n\n{errors_resolved}"
sysexit_with_message(msg, code=1)


Expand Down
2 changes: 1 addition & 1 deletion tests/unit/test_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,7 @@ def test_validate_exists_when_validation_fails( # noqa: D103
config_instance: config.Config,
) -> None:
m = mocker.patch("molecule.model.schema_v3.validate")
m.return_value = "validation errors"
m.return_value = ["validation errors"]

with pytest.raises(SystemExit) as e:
config_instance._validate()
Expand Down
Loading