Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 4, 2025

Addresses feedback on PR #279 regarding malformed SQL in the condition occurrence duplicate detection logic.

Changes

  • Fixed SQL syntax error in ConditionOccurrenceRecorder.cs lines 125 and 134
  • Changed or and to or in both WHERE clauses that check for duplicate records
-- Before (invalid SQL)
and (co.condition_concept_id != 0 or and co.condition_source_value = r.condition_source_value)

-- After
and (co.condition_concept_id != 0 or co.condition_source_value = r.condition_source_value)

The duplicate detection now correctly checks if either the condition_concept_id is non-zero OR the source values match, when determining whether a condition occurrence already exists.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@james-cockayne james-cockayne marked this pull request as ready for review November 4, 2025 14:11
@james-cockayne james-cockayne merged commit b7f9794 into feature/map_to_unknown_concept Nov 4, 2025
1 check passed
@james-cockayne james-cockayne deleted the copilot/sub-pr-279-again branch November 4, 2025 14:11
Copy link
Contributor Author

Copilot AI commented Nov 4, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • www.datadictionary.nhs.uk
    • Triggering command: dotnet /home/REDACTED/work/oxford-omop-data-mapper/oxford-omop-data-mapper/OmopTransformer/bin/Debug/net8.0/omop.dll docs /home/REDACTED/work/oxford-omop-data-mapper/oxford-omop-data-mapper/OmopTransformer/../docs/transformation-documentation (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] WIP address feedback to map unknown concepts to 0 Fix SQL syntax error in ConditionOccurrenceRecorder duplicate detection Nov 4, 2025
Copilot AI requested a review from james-cockayne November 4, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants