-
Notifications
You must be signed in to change notification settings - Fork 0
maint: Tech review #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 38 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
eaf0b5d
maint: Tech review
AlejandroFernandezLuces 35a55b3
fix: Several changes
AlejandroFernandezLuces 671eebb
feat: Use ruff in pre-commit
AlejandroFernandezLuces 98436a3
feat: Add contributing guide
AlejandroFernandezLuces 965b643
fix: Add argparse and update readme
AlejandroFernandezLuces 3cb10f3
fix: Rename
AlejandroFernandezLuces cc13384
maint: Add labeler
AlejandroFernandezLuces c3a506d
maint: Add smoke tests
AlejandroFernandezLuces 67a1971
Merge main branch
AlejandroFernandezLuces 60e57cf
doc: Add docs
AlejandroFernandezLuces 3e17373
maint: Add doc build action
AlejandroFernandezLuces 7609514
fix: Vale structure
AlejandroFernandezLuces 5f05a36
fix: Add vale ini
AlejandroFernandezLuces 51e10a0
fix: Admit flowkit
AlejandroFernandezLuces 98189d2
fix: Temp ignore repo link
AlejandroFernandezLuces 85d5bbc
maint: Add documentation deploy
AlejandroFernandezLuces 1966223
fix: Add package name
AlejandroFernandezLuces 0fa6789
fix: Add package action
AlejandroFernandezLuces 32f1be7
fix: Version getter
AlejandroFernandezLuces cd9fb40
maint: Add license and license header action
AlejandroFernandezLuces cfc5972
maint: Add license headers
AlejandroFernandezLuces c905487
fix: restore dockerfile defaults
AlejandroFernandezLuces 9d4a91c
Merge main branch
AlejandroFernandezLuces e6d856b
fix: Several small fixes
AlejandroFernandezLuces 5418acf
fix: Adapt tests to new changes
AlejandroFernandezLuces e7c6b89
fix: Imports
AlejandroFernandezLuces 548e741
fix: Adapt CICD tests
AlejandroFernandezLuces ee57819
fix: String import
AlejandroFernandezLuces 9f64e93
fix: Add asyncio plugin
AlejandroFernandezLuces b21491b
fix: pytest folder struct
AlejandroFernandezLuces 352896a
Apply suggestions from code review
AlejandroFernandezLuces 7a8b2e1
fix: Comments
AlejandroFernandezLuces 870740e
Merge branch 'maint/tech-review' of https://github.com/ansys/allie-fl…
AlejandroFernandezLuces c3056e7
fix: Contributing docs
AlejandroFernandezLuces f0a9173
fix: Remove packaging from CICD
AlejandroFernandezLuces 950e75c
Update doc/source/index.rst
AlejandroFernandezLuces 4dabd1a
fix: Update ansys actions
AlejandroFernandezLuces dd00219
Merge branch 'maint/tech-review' of https://github.com/ansys/allie-fl…
AlejandroFernandezLuces 185d1a2
fix: Dockerfile and readme
AlejandroFernandezLuces File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
documentation: | ||
- changed-files: | ||
- any-glob-to-any-file: ['doc/source/**/*', 'README.md'] | ||
|
||
maintenance: | ||
- changed-files: | ||
- any-glob-to-any-file: ['.github/**/*', 'pyproject.toml', '.pre-commit-config.yaml'] | ||
|
||
testing: | ||
- changed-files: | ||
- any-glob-to-any-file: ['tests/*'] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
- name: bug | ||
description: Something isn't working | ||
color: d42a34 | ||
|
||
- name: dependencies | ||
description: Related with project dependencies | ||
color: ffc0cb | ||
|
||
- name: documentation | ||
description: Improvements or additions to documentation | ||
color: 0677ba | ||
|
||
- name: enhancement | ||
description: New features or code improvements | ||
color: FFD827 | ||
|
||
- name: good first issue | ||
description: Easy to solve for newcomers | ||
color: 62ca50 | ||
|
||
- name: maintenance | ||
description: Package and maintenance related | ||
color: f78c37 | ||
|
||
- name: release | ||
description: Anything related to an incoming release | ||
color: ffffff | ||
|
||
- name: testing | ||
description: Anything related to testing | ||
color: 5802B8 | ||
|
||
- name: graphics | ||
description: Anything related to graphics | ||
color: 5903A8 | ||
|
||
- name: triage | ||
description: Need some assessment | ||
color: f78a50 | ||
|
||
- name: top priority | ||
description: Must be fixed promptly | ||
color: ab8a50 | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,36 +1,35 @@ | ||
repos: | ||
- repo: https://github.com/psf/black | ||
rev: 23.12.1 | ||
- repo: https://github.com/adamchainz/blacken-docs | ||
rev: 1.18.0 | ||
hooks: | ||
- id: black | ||
|
||
- repo: https://github.com/pycqa/isort | ||
rev: 5.13.2 | ||
hooks: | ||
- id: isort | ||
|
||
- repo: https://github.com/PyCQA/flake8 | ||
rev: 6.1.0 | ||
hooks: | ||
- id: flake8 | ||
|
||
- repo: https://github.com/pycqa/pydocstyle | ||
rev: 6.3.0 | ||
hooks: | ||
- id: pydocstyle | ||
args: ["--ignore=D205,D100,D213,D203"] | ||
exclude: examples | ||
additional_dependencies: [toml] | ||
- id: blacken-docs | ||
additional_dependencies: [black==23.12.1] | ||
|
||
- repo: https://github.com/pre-commit/pre-commit-hooks | ||
rev: v4.5.0 | ||
rev: v4.6.0 | ||
hooks: | ||
- id: check-merge-conflict | ||
- id: debug-statements | ||
- id: check-yaml | ||
- id: trailing-whitespace | ||
|
||
- repo: https://github.com/python-jsonschema/check-jsonschema | ||
rev: 0.27.3 | ||
rev: 0.29.1 | ||
hooks: | ||
- id: check-github-workflows | ||
|
||
|
||
- repo: https://github.com/astral-sh/ruff-pre-commit | ||
rev: v0.5.7 | ||
hooks: | ||
- id: ruff | ||
args: [--fix] | ||
- id: ruff-format | ||
|
||
- repo: https://github.com/ansys/pre-commit-hooks | ||
rev: v0.4.3 | ||
hooks: | ||
- id: check-github-workflows | ||
- id: add-license-headers | ||
files: '(src|examples|tests|docker)/.*\.(py)|\.(proto)' | ||
args: | ||
- --start_year=2024 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
# This is the list of allie-flowkit-python's significant contributors. | ||
# | ||
# This file does not necessarily list everyone who has contributed code. | ||
# | ||
# For contributions made under a Corporate CLA, the organization is | ||
# added to this file. | ||
# | ||
# If you have contributed to the repository and wish to be added to this file | ||
# please submit a request. | ||
# | ||
# | ||
ANSYS, Inc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
# Contributor covenant code of conduct | ||
|
||
## Pledge | ||
|
||
In the interest of fostering an open and welcoming environment, | ||
all contributors and maintainers pledge to making participation | ||
in the Ansys project and community a harassment-free experience | ||
for everyone, regardless of age, body size, disability, ethnicity, | ||
sex characteristics, gender identity and expression, level of | ||
experience, education, socioeconomic status, nationality, personal | ||
appearance, race, religion, or sexual identity and orientation. | ||
|
||
## Standards | ||
|
||
Examples of behavior that contribute to creating a positive environment | ||
include: | ||
|
||
* Using welcoming and inclusive language | ||
* Being respectful of differing viewpoints and experiences | ||
* Gracefully accepting constructive criticism | ||
* Focusing on what is best for the community | ||
* Showing empathy towards other community members | ||
|
||
Examples of unacceptable behavior by participants include: | ||
|
||
* The use of sexualized language or imagery and unwelcome sexual | ||
attention or advances | ||
* Trolling, insulting/derogatory comments, and personal or political attacks | ||
* Public or private harassment | ||
* Publishing others' private information, such as a physical or electronic | ||
address, without explicit permission | ||
* Other conduct which could reasonably be considered inappropriate in a | ||
professional setting | ||
|
||
## Responsibilities | ||
|
||
Project maintainers are responsible for clarifying the standards of acceptable | ||
behavior and are expected to take appropriate and fair corrective action in | ||
response to any instances of unacceptable behavior. | ||
|
||
Project maintainers have the right and responsibility to remove, edit, or reject | ||
comments, commits, code, wiki edits, issues, and other contributions that are | ||
not aligned to this Code of Conduct, or to ban temporarily or permanently any | ||
contributor for other behaviors that they deem inappropriate, threatening, | ||
offensive, or harmful. | ||
|
||
## Scope | ||
|
||
This Code of Conduct applies both within project spaces and in public spaces | ||
when an individual is representing the project or its community. Examples of | ||
representing a project or community include using an official project email | ||
address, posting using an official social media account, or acting as an appointed | ||
representative at an online or offline event. Representation of a project may be | ||
further defined and clarified by project maintainers. | ||
|
||
## Attribution | ||
|
||
This code of conduct is adapted from the [Contributor Covenant][homepage], | ||
version 1.4, available at | ||
https://www.contributor-covenant.org/version/1/4/code-of-conduct.html | ||
|
||
[homepage]: https://www.contributor-covenant.org | ||
|
||
For answers to common questions about this code of conduct, see | ||
https://www.contributor-covenant.org/faq |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
# Contribute | ||
|
||
Overall guidance on contributing to a PyAnsys library appears in the | ||
AlejandroFernandezLuces marked this conversation as resolved.
Show resolved
Hide resolved
|
||
*Contributing* topic in the *[PyAnsys developer's guide]*. Ensure that you | ||
are thoroughly familiar with this guide before attempting to contribute to | ||
allie-flowkit-python. For contributing to this project, please refer to the | ||
[Contributing] section of this project's documentation. | ||
|
||
[PyAnsys Developer's Guide]: https://dev.docs.pyansys.com/index.html | ||
[Contributing]: expert-adventure-nvnoo1y.pages.github.io/dev/contributing.html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
# Contributors | ||
|
||
## Project Lead or Owner | ||
|
||
* [Laura Sanchez-Gallego Kadri](https://github.com/laurasgkadri98) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
MIT License | ||
|
||
Copyright (c) 2024 ANSYS, Inc. and/or its affiliates. | ||
|
||
Permission is hereby granted, free of charge, to any person obtaining a copy of | ||
this software and associated documentation files (the "Software"), to deal in | ||
the Software without restriction, including without limitation the rights to | ||
use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies | ||
of the Software, and to permit persons to whom the Software is furnished to do | ||
so, subject to the following conditions: | ||
|
||
The above copyright notice and this permission notice shall be included in all | ||
copies or substantial portions of the Software. | ||
|
||
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
SOFTWARE. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.