Skip to content

Conversation

Revathyvenugopal162
Copy link
Contributor

@Revathyvenugopal162 Revathyvenugopal162 commented May 9, 2025

partially fix #683

  • Adjust the width of the search bar to allign with nav bar
  • Search is now working with smaller media

Note

Open the details to see images in different media

Details

media images
phone Screenshot 2025-05-12 at 15 08 35
phone 2 Screenshot 2025-05-12 at 15 09 44
tablet Screenshot 2025-05-12 at 15 09 57
laptop Screenshot 2025-05-12 at 10 24 36

More images

Ansys actions with this branch

Screenshot 2025-05-12 at 10 25 04

Ansys actions docs before

Screenshot 2025-05-12 at 10 12 36

@github-actions github-actions bot added ui/ux Related with UI/UX design js Requires or modifies JavaScript code fix Pull requests related to resolving problems or errors labels May 9, 2025
@Revathyvenugopal162 Revathyvenugopal162 marked this pull request as ready for review May 12, 2025 08:19
@Revathyvenugopal162 Revathyvenugopal162 requested a review from a team as a code owner May 12, 2025 08:19
Copy link
Contributor

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cant really comment on the code changes... I do not understand much of the code there...

But... I think we went a bit too agressive... Under 1200px

image

Where ideally, we should have or the navbar elements or the search bar, at least until the mentioned 960px.

Am I right? If you think make this to happen will take you time, I would merge this and figure out the rest in a follow up PR.

When the width is bigger than 1200px:

image

@Revathyvenugopal162
Copy link
Contributor Author

I cant really comment on the code changes... I do not understand much of the code there...

But... I think we went a bit too agressive... Under 1200px

image Where ideally, we should have or the navbar elements or the search bar, at least until the mentioned 960px.

Am I right? If you think make this to happen will take you time, I would merge this and figure out the rest in a follow up PR.

When the width is bigger than 1200px:

image

i doo agree with 1040Px, i think we can do the flexibility with the other PR #696

@germa89
Copy link
Contributor

germa89 commented May 27, 2025

@Revathyvenugopal162 do you need any input/help here?

@Revathyvenugopal162
Copy link
Contributor Author

@germa89 we can merge this PR after we merge #674 , since there will be conflict with the js script

Copy link
Member

@jorgepiloto jorgepiloto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, @Revathyvenugopal162. Everything working nice.

@Revathyvenugopal162
Copy link
Contributor Author

Thank you for the review and suggestion @jorgepiloto and @germa89 . Merging

@Revathyvenugopal162 Revathyvenugopal162 merged commit 9ec925c into main May 28, 2025
19 checks passed
@Revathyvenugopal162 Revathyvenugopal162 deleted the fix/screen-view branch May 28, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Pull requests related to resolving problems or errors js Requires or modifies JavaScript code ui/ux Related with UI/UX design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page view is a bit off
5 participants