Skip to content

refactor: update color variables for improved theme consistency and simplicity #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

germa89
Copy link
Contributor

@germa89 germa89 commented May 13, 2025

As the title.

I think there are colors that are not too diferent from existing ones, so I would propose to simplify the color palette by deleting colors that are very similar to each other.

Proposed changes:

replacing #f2f2f2 with #f5f5f5 (distance: 0.02037)
replacing #ececec with #f5f5f5 (distance: 0.06113)
replacing #91969b with #929591 (distance: 0.03960)
replacing #282828 with #1b2431 (distance: 0.06395)
replacing #579ce5 with #6495ed (distance: 0.06585)
replacing #f2f4f6 with #f5f5f5 (distance: 0.01300)
replacing #d6ab1e with #daa520 (distance: 0.02934)
replacing #b12422 with #b22222 (distance: 0.00876)
image

@germa89 germa89 requested a review from a team as a code owner May 13, 2025 10:37
@germa89 germa89 self-assigned this May 13, 2025
@jorgepiloto
Copy link
Member

Hi @germa89, are these shipped with PyData Sphinx Theme? Where did you find them?

@germa89
Copy link
Contributor Author

germa89 commented May 13, 2025

Hi @germa89, are these shipped with PyData Sphinx Theme? Where did you find them?

those are colors defined in the ansys-sphinx-theme but that are very similar to each other. I did not define new colours. Although I think we should standarise the colors. See my other PR: #697

@Revathyvenugopal162
Copy link
Contributor

As I already mentioned in the SCSS refactoring PR (before), I added all the colors based on the suggestions from the UX team. I didn't refactor all the colors in the other PR #644, as you noted, because the AWC (Ansys Web Components) were not available at that time. Now that AWC is available, we can start using it across the websites.

So maybe we can also try updating our SCSS files to define colors as in
#697 that align more closely with the official Ansys UX specifications.

I am open to change these colors as there is no much different (if UX is ok) or reuse the AWC .

@mia-guo-ux
Copy link

@Revathyvenugopal162 @germa89 @jorgepiloto
As mentioned by Revathy, we should align with AWC colors as closely as possoble.

@MaxJPRey
Copy link
Contributor

MaxJPRey commented Jun 4, 2025

Should we dismiss this PR based on @Revathyvenugopal162 and @mia-guo-ux 's explanations.

@germa89
Copy link
Contributor Author

germa89 commented Jun 4, 2025

Should we dismiss this PR based on @Revathyvenugopal162 and @mia-guo-ux 's explanations.

I don't mind.

But I would reiterate that I did not introduce any new colour. I just took all the colours in the theme and reduced them by selecting the ones that are very similar to each other. (I basically did group them by similarity)
If we use less colors, it is easier to keep track of changes and I guess it is easier for developers.

@germa89 germa89 closed this Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants