-
Notifications
You must be signed in to change notification settings - Fork 8
refactor: update color variables for improved theme consistency and simplicity #695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…/github.com/ansys/ansys-sphinx-theme into refactor/remove-non-different-enough-colors
Hi @germa89, are these shipped with PyData Sphinx Theme? Where did you find them? |
As I already mentioned in the SCSS refactoring PR (before), I added all the colors based on the suggestions from the UX team. I didn't refactor all the colors in the other PR #644, as you noted, because the AWC (Ansys Web Components) were not available at that time. Now that AWC is available, we can start using it across the websites. So maybe we can also try updating our SCSS files to define colors as in I am open to change these colors as there is no much different (if UX is ok) or reuse the AWC . |
@Revathyvenugopal162 @germa89 @jorgepiloto |
Should we dismiss this PR based on @Revathyvenugopal162 and @mia-guo-ux 's explanations. |
I don't mind. But I would reiterate that I did not introduce any new colour. I just took all the colours in the theme and reduced them by selecting the ones that are very similar to each other. (I basically did group them by similarity) |
As the title.
I think there are colors that are not too diferent from existing ones, so I would propose to simplify the color palette by deleting colors that are very similar to each other.
Proposed changes: