feat: add backstop js test #804
Conversation
github-actions
bot
added
the
enhancement
|
The documentation for this pull request will be available at https://sphinxdocs.ansys.com/pull/804. Please allow some time for the documentation to be deployed. |
jorgepiloto
left a comment
jorgepiloto
left a comment
There was a problem hiding this comment.
Almost there! Just making sure we use the latest version for the actions in CI/CD and that commands are cross-platform.
tox.ini
Outdated
| description = Checks for project unit tests and coverage (if desired) | ||
| basepython = | ||
| {code-style,doc-style,doc-links,doc-html}: python3 | ||
| description = Run BackstopJS visual regression tests |
There was a problem hiding this comment.
This command is not cross-platform yet. We need to ensure it runs no matter the platform.
I understand the goal is to serve the pages in the local machine and then run the tests against them.
We can explore if Tox supports parallel commands or we can achieve something similar to that.
|
I'll fix the Tox suggestions so we can merge this. No worries. |
.github/workflows/backstop.yml
Outdated
| - name: Set up Node | ||
| uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 | ||
| with: | ||
| node-version: "20" |
There was a problem hiding this comment.
Any chance we can use the latest version?
There was a problem hiding this comment.
yes, we can update, i will keep this as an env variable
No description provided.