-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add fullpath to set UDS sock filename #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds the ability to specify a custom full path for Unix Domain Socket (UDS) files via a new uds_fullpath parameter, allowing callers to bypass the predefined naming convention ({uds_service}-{uds_id}.sock).
Key changes:
- Added
uds_fullpathparameter tocreate_channel,create_uds_channel, andverify_uds_socketfunctions - Modified logic to prioritize
uds_fullpathwhen provided, falling back to the existinguds_service/uds_dir/uds_idpattern - Updated documentation to describe the new parameter
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/ansys/tools/common/cyberchannel.py | Added uds_fullpath parameter to channel creation functions and socket verification, with conditional logic to use custom path or fall back to existing convention |
| doc/source/changelog/114.miscellaneous.md | Added changelog entry for the new feature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
RobPasMue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid breaking changes - please move the location of the uds_fullpath to the last entry of the uds_* related variables, not the first one
…tools-common into earnal/uds_fullpath
Goal is to let caller to be able to customize the fullpath of the UDS socket file.
Previous version was limited to the use of this predefined convention:
Now the caller can send the fullpath of the socket file with parameter
uds_fullpath: