Skip to content

Conversation

@AlejandroFernandezLuces
Copy link
Collaborator

Lazy import trame modules and add numpy to type checking to reduce the import time of the library. Should be about 34% less loading time.

Stats on my system:

Before:
Capture

After:
Capture2

Closes #162

@AlejandroFernandezLuces
Copy link
Collaborator Author

Pinging @germa89 for visibility.

@github-actions github-actions bot added the bug Something isn't working label Oct 30, 2024
Copy link
Contributor

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for this. Just a minor consideration before merging.

@github-actions github-actions bot added the maintenance Package and maintenance related label Oct 31, 2024
@AlejandroFernandezLuces AlejandroFernandezLuces merged commit b3025ef into main Oct 31, 2024
25 checks passed
@AlejandroFernandezLuces AlejandroFernandezLuces deleted the fix/reduce-import-time branch October 31, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trame greatly increases loading time

4 participants