Skip to content

Conversation

@germa89
Copy link
Contributor

@germa89 germa89 commented Dec 11, 2024

Fix #206

@germa89 germa89 self-assigned this Dec 11, 2024
@github-actions github-actions bot added the bug Something isn't working label Dec 11, 2024
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@AlejandroFernandezLuces AlejandroFernandezLuces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for fixing it 🙂

@germa89 germa89 merged commit 908278c into main Dec 11, 2024
25 checks passed
@germa89 germa89 deleted the fix/duplicated-off_screen-argument branch December 11, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PyVistaInterface is using off_screen without checking if it is part of plotter_kwargs

5 participants