Skip to content

Conversation

@germa89
Copy link
Contributor

@germa89 germa89 commented Dec 11, 2024

As the title.

Close #208 by implementing our own meshes method.

@germa89 germa89 self-assigned this Dec 11, 2024
@github-actions github-actions bot added the bug Something isn't working label Dec 11, 2024
@germa89
Copy link
Contributor Author

germa89 commented Dec 11, 2024

This method wasn't tested, so I leave it up to @AlejandroFernandezLuces if he wants to add a tests or not.

I guess it should not be needed since the slicer (MeshSliderWidget) does not seem to be much exposed??

Copy link
Contributor Author

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue has been fixed upstream in pyvista/pyvista#6860.
It is just yet not published.

germa89

This comment was marked as duplicate.

@germa89 germa89 mentioned this pull request Dec 11, 2024
@AlejandroFernandezLuces
Copy link
Collaborator

This method wasn't tested, so I leave it up to @AlejandroFernandezLuces if he wants to add a tests or not.

I guess it should not be needed since the slicer (MeshSliderWidget) does not seem to be much exposed??

Since this is temporary I think we don't need to test it. Let's merge this if you need it and we can remove it when bumping the next PyVista version.

@AlejandroFernandezLuces AlejandroFernandezLuces merged commit f1c778e into main Dec 12, 2024
25 checks passed
@AlejandroFernandezLuces AlejandroFernandezLuces deleted the fix/meshes branch December 12, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vtk 9.4.0 fails

4 participants