feat: Add dark mode when background is dark #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlejandroFernandezLuces
changed the title
RobPasMue
approved these changes
Jan 14, 2025
Member
RobPasMue
left a comment
RobPasMue
left a comment
There was a problem hiding this comment.
Overall looks good, just left some opinionated suggestions but feel free to disregard if you prefer =)
src/ansys/tools/visualization_interface/backends/pyvista/widgets/screenshot.py
Outdated
Show resolved
Hide resolved
src/ansys/tools/visualization_interface/backends/pyvista/widgets/ruler.py
Outdated
Show resolved
Hide resolved
src/ansys/tools/visualization_interface/backends/pyvista/widgets/hide_buttons.py
Outdated
Show resolved
Hide resolved
RobPasMue
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Changes the color of the buttons and the ruler widget to white when the background color is below a threshold, or when selected by the user with
pl.show(dark_mode=True).Pinging @Samuelopez-ansys for visibility
Screenshot with a black background
