Skip to content

fix: pyvista read-only behaviour #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 21, 2025
Merged

fix: pyvista read-only behaviour #281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
825315f
fix: pyvista read-only behaviour
RobPasMue Apr 21, 2025
2bec3c3
Update pyvista_interface.py
RobPasMue Apr 21, 2025
83835a8
chore: adding changelog file 281.fixed.md [dependabot-skip]
pyansys-ci-bot Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/changelog.d/281.fixed.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
fix: pyvista read-only behaviour
6 changes: 5 additions & 1 deletion src/ansys/tools/visualization_interface/backends/pyvista/pyvista_interface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,11 @@ def clip(
Clipped mesh.
"""
return mesh.clip(normal=plane.normal, origin=plane.origin)
# Make sure to pass new copies/objects to the mesh for the normal
# This should be fixed by PyVista eventually... it is coming from
# https://github.com/pyvista/pyvista/commit/2db1888a294a14e4f28a140d8aa0466d332912dc
return mesh.clip(normal=[elem for elem in plane.normal],
Copy link

@ahernsean ahernsean Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about:

return mesh.clip(normal=plane.normal.copy(), origin=plane.origin)

or

return mesh.clip(normal=plane.normal[:], origin=plane.origin)

to make the intent clearer?

Copy link

@ahernsean ahernsean Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind. Already merged

Copy link
Member Author

@RobPasMue RobPasMue Apr 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ahernsean -- no worries, this should be a temporary fix. See pyvista/pyvista#7446

Nonetheless, we can't just assume "copy()" will exist since the type can be a simple tuple/list (for which the copy() method doesn't exist). Option 2 could be valid but I'd rather fix it in PyVista and remove this hack altogether.

origin=plane.origin)

def plot_meshobject(self, custom_object: MeshObjectPlot, **plotting_options):
"""Plot a generic ``MeshObjectPlot`` object to the scene.
Expand Down
Loading