Skip to content

fix: Mesh slider unclick makes buttons disappear #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 30, 2025
Merged

fix: Mesh slider unclick makes buttons disappear #362

merged 4 commits into from
Sep 30, 2025

Conversation

@AlejandroFernandezLuces
Copy link
Collaborator

@AlejandroFernandezLuces AlejandroFernandezLuces commented Sep 30, 2025 •
edited
Loading

There were two bugs related to the mesh slicer button:

  1. A key error was always being raised, solved by checking first that the key exists in the dict.
  2. When unclicking the slicer, buttons visually disappeared from the screen. Now buttons are being reset on unclick to avoid this.

@github-actions github-actions bot added the bug Something isn't working label Sep 30, 2025
@AlejandroFernandezLuces AlejandroFernandezLuces marked this pull request as ready for review September 30, 2025 08:08
RobPasMue
RobPasMue approved these changes Sep 30, 2025
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AlejandroFernandezLuces AlejandroFernandezLuces merged commit 8118675 into main Sep 30, 2025
27 checks passed
@AlejandroFernandezLuces AlejandroFernandezLuces deleted the fix/mesh-slicer branch September 30, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RobPasMue RobPasMue RobPasMue approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AlejandroFernandezLuces @RobPasMue @pyansys-ci-bot