Skip to content

Conversation

@AlejandroFernandezLuces
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 30, 2025
@AlejandroFernandezLuces AlejandroFernandezLuces marked this pull request as ready for review September 30, 2025 12:40
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs look good but I would ask @PipKat to have a look at them

@AlejandroFernandezLuces AlejandroFernandezLuces linked an issue Oct 1, 2025 that may be closed by this pull request
Copy link
Member

@PipKat PipKat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the suggested edits are style-related or for adding links to better direct the user to information.

@PipKat
Copy link
Member

PipKat commented Oct 6, 2025

Alex K. once told me that we should include () after function and method names. I'm just putting that out there if you want to make such changes globally.

@AlejandroFernandezLuces
Copy link
Collaborator Author

Alex K. once told me that we should include () after function and method names. I'm just putting that out there if you want to make such changes globally.

I can do it for the references in the examples, but in the documentation, when referencing and linking to the API reference, the parentheses do not appear:

image

I would prefer to not have the parentheses for consistency, they cannot be added to these references. What do you think?

@PipKat
Copy link
Member

PipKat commented Oct 7, 2025

Alex K. once told me that we should include () after function and method names. I'm just putting that out there if you want to make such changes globally.

I can do it for the references in the examples, but in the documentation, when referencing and linking to the API reference, the parentheses do not appear:

image I would prefer to not have the parentheses for consistency; they cannot be added to these references. What do you think?

It agree it makes sense not to as consistency here would be preferred. What is the trick to having just the last part of the long API shown as the display link--with the full API path shown as the tooltip? I just recommended another developer try to implement this technique in his PR but forgot how it was done!

@AlejandroFernandezLuces
Copy link
Collaborator Author

What is the trick to having just the last part of the long API shown as the display link--with the full API path shown as the tooltip?

The tilde at the beginning is what tells Sphinx to only show the last bit:

:class:`~ansys.tools.visualization_interface.backends.pyvista.PyVistaBackendInterface`

@AlejandroFernandezLuces AlejandroFernandezLuces merged commit 06f3974 into main Oct 8, 2025
23 checks passed
@AlejandroFernandezLuces AlejandroFernandezLuces deleted the doc/migration-guide branch October 8, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migration guide

5 participants