-
Notifications
You must be signed in to change notification settings - Fork 0
Address example notebook formatting issues #805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 9e1faea.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #805 +/- ##
=======================================
Coverage 97.88% 97.88%
=======================================
Files 28 28
Lines 3124 3124
=======================================
Hits 3058 3058
Misses 66 66
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…/grantami-bomanalytics into doc/fix-example-formatting
Going through the process manually (i.e. creating an ipynb from the .py file in jupyter, running the example, then exporting to HTML) seems to work, although it generates static plots instead of the interactive ones we get currently. I think there's some more investigation needed to resolve this. To unblock us though, I think we should merge this, and I'll create a separate issue to investigate what's going on with plotly >=6.1. I don't think it's necessary to pin to an earlier version in pyproject.toml, since plotly still works when running the examples. It's just that as part of our CI, it doesn't do what we expect. |
Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: pyansys-ci-bot <[email protected]>
Closes #804
I did not modify the sustainability notebook which was the trigger for the underlying issue, this is fixed in #803
TODO:
Identify underlying issue with plotly update and create Issue in plotly repo if necessary. I initially thought Fix issue breaking- Created Notebook to HTML conversion not rendering plots with plotly >=6.1 #807fig.write_image()
plotly/plotly.py#5193, but this was already included in the version we upgraded to.