- 
                Notifications
    
You must be signed in to change notification settings  - Fork 1
 
CHORE: Update missing or outdated files #911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
          Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@           Coverage Diff           @@
##             main     #911   +/-   ##
=======================================
  Coverage   94.97%   94.97%           
=======================================
  Files         110      110           
  Lines        5773     5773           
  Branches      296      296           
=======================================
  Hits         5483     5483           
  Misses        289      289           
  Partials        1        1           
 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
  | 
    
| 
           @ansys/pyansys-core I think it would be useful for each updated file to be a separate PR. Here, the  As for the  
  | 
    
| 
           Good feedback @greschd ! As to why we are submitting it as a full PR - it is mostly to minimize the number of PRs submitted. We've got both types of feedback in the past regarding this approach (submit a single PR with all changes -- vs -- submit individual PRs for each file). Regarding the  
  | 
    
          
 Might be good to simply link to that repo in the PR description? I think it's non-obvious if you don't already know where that is. As for this specific change, I didn't find any additional info when looking at the maintenance repository. Specifically, would you adapt also the section in the rendered docs, or only the   | 
    
          
 Ah - great idea! Let's add that as part of the body comment @klmcadams 
 We were only targeting the content of the  We should revisit the template repo to make sure that both the automation repo and the template are aligned. That's also a good point. Let's track all this as an issue in the automation repo.  | 
    
| 
           @greschd @RobPasMue For context, I was using this template for the CONTRIBUTING.md file since that's the one we refer to in the technical review: https://dev.docs.pyansys.com/packaging/structure.html#the-contributing-md-file Could it make sense to append the CONTRIBUTING.md template to the top of the file rather than re-writing it, so it still keeps existing information?  | 
    
          
 I think it's okay to rewrite.. if it differs significantly enough, it makes sense that there needs to be some manual intervention. As a general escape hatch, is it possible to opt-out for specific files, or only globally (not that I'd want to opt out here)?  | 
    
| 
           @greschd I believe right now it's only possible to opt out globally, but I think the option to opt out of specific files could be nice depending on the case @RobPasMue  | 
    
The following files were added or updated:
CODE_OF_CONDUCT.mdfile containing the contributor covenant code of conductCONTRIBUTING.mdfile with contribution guidelines specific to the repositoryImportant
Replace {project-name} with the name of the project in the
CONTRIBUTING.mdfile. For example, the project name for ansys/pymechanical is PyMechanical.This pull request was created by a bot. If you have any questions, please ping the PyAnsys Core team for assistance. To ping the team write a comment in this issue with the following mention:
@ansys/pyansys-core.If you want this repository to be excluded from this automated maintenance process, please let us know by filling in the opt-out request form.