Draft
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6595 +/- ##
===========================================
- Coverage 83.32% 28.40% -54.92%
===========================================
Files 246 246
Lines 77442 77808 +366
===========================================
- Hits 64527 22104 -42423
- Misses 12915 55704 +42789 🚀 New features to boost your workflow:
|
…nsys/pyaedt into feat/waveport_object_alignment
…nsys/pyaedt into feat/waveport_object_alignment
Contributor
Devin-Crawford
left a comment
There was a problem hiding this comment.
Still lots of work to do on this.
Member
|
Next week I will review it, thank you @eblanco-ansys for this great contribution |
Contributor
|
The unit test now creates only one box for the waveguide, but it creates multiple port instances on the same face which would lead to an invalid project. It would be good to
|
Contributor
|
@eblanco-ansys : Actually it would be good to raise an exception if trying to assign a port to a face where a port has already been assigned ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added WavePortObject class to handle waveport advanced configuration in HFSS
Issue linked
Checklist