Conversation
- Modified assign_coil in maxwell.py to handle multiple object assignments as CoilGroup - Updated test_assign_coil_group in test_27_Maxwell2D.py with comprehensive boundary counting validation - Updated test_create_coil_group in test_28_Maxwell3D.py for 3D coil terminal groups - Added proper boundary type validation and object assignment verification
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (3.12%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #6855 +/- ##
===========================================
+ Coverage 44.50% 57.12% +12.61%
===========================================
Files 245 245
Lines 77613 77639 +26
===========================================
+ Hits 34544 44348 +9804
+ Misses 43069 33291 -9778 🚀 New features to boost your workflow:
|
Member
|
Converted to draft until tests pass locally |
Contributor
|
Hi @pvinod13 @gchaturve, Thanks for taking the time to look into this issue :) |
Contributor
Author
|
[like] Vinod Kumar Pallapati reacted to your message:
…________________________________
From: Giulia Malinverno ***@***.***>
Sent: Monday, January 26, 2026 3:55:11 PM
To: ansys/pyaedt ***@***.***>
Cc: Vinod Kumar Pallapati ***@***.***>; Mention ***@***.***>
Subject: Re: [ansys/pyaedt] FEAT: Assign coil group (PR #6855)
[External Sender]
[https://avatars.githubusercontent.com/u/103059376?s=20&v=4]gmalinve left a comment (ansys/pyaedt#6855)<#6855 (comment)>
Hi @pvinod13<https://github.com/pvinod13> @gchaturve<https://github.com/gchaturve>, Thanks for taking the time to look into this issue :)
I branch out your branch and you should update it to the latest main since many things have changed since you last open this PR.
You have a minor conflict because the tests you touched are no longer there so I'll suggest to move to the new maxwell test files.
Coul you please update the PR, run the tests and let me know once it's ready to review again?
Thanks! :)
—
Reply to this email directly, view it on GitHub<#6855 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A2OSR6FYEAKD7VN5FKGKYY34IY2F7AVCNFSM6AAAAACLFZ2MCWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTQMBQGMZTCMRYGA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please provide a brief description of the changes made in this pull request.
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist