FEAT: add fields calc expressions and update fields distribution extension#6996
Merged
FEAT: add fields calc expressions and update fields distribution extension#6996
Conversation
Contributor
Author
|
@SMoraisAnsys @Samuelopez-ansys is there a reason why we don't have anymore fields_calculator tests? I remember we had them in the past. Am I missing something? |
eblanco-ansys
previously approved these changes
Dec 10, 2025
eblanco-ansys
previously approved these changes
Dec 10, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6996 +/- ##
==========================================
- Coverage 83.51% 82.07% -1.45%
==========================================
Files 254 254
Lines 77338 77348 +10
==========================================
- Hits 64590 63482 -1108
- Misses 12748 13866 +1118 🚀 New features to boost your workflow:
|
SMoraisAnsys
previously approved these changes
Jan 8, 2026
Collaborator
SMoraisAnsys
left a comment
There was a problem hiding this comment.
LGTM, I left some minor comment mainly over:
- Splitting a test into 3 parts for readability: setup, exercise, assert (we don't need a teardown)
- Asking to move the patchs outside of the test content (as decorator) to ease readability
Thanks again for this changes @gmalinve
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
…o feat/get_fields_expressions
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
…o feat/get_fields_expressions
…o feat/get_fields_expressions
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
SMoraisAnsys
reviewed
Jan 9, 2026
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
From 2026.1 there is a new API method to get all fields calc. expressions and I also took the opportunity to refacto the fields calc class + add new tests that didn't exist.
Issue linked
#6995
Checklist