Skip to content

FEAT: add fields calc expressions and update fields distribution extension#6996

Merged
gmalinve merged 46 commits intomainfrom
feat/get_fields_expressions
Jan 12, 2026
Merged

FEAT: add fields calc expressions and update fields distribution extension#6996
gmalinve merged 46 commits intomainfrom
feat/get_fields_expressions

Conversation

@gmalinve
Copy link
Contributor

@gmalinve gmalinve commented Dec 10, 2025

Description

From 2026.1 there is a new API method to get all fields calc. expressions and I also took the opportunity to refacto the fields calc class + add new tests that didn't exist.

Issue linked

#6995

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@gmalinve gmalinve self-assigned this Dec 10, 2025
@gmalinve gmalinve requested a review from a team as a code owner December 10, 2025 14:33
@gmalinve gmalinve linked an issue Dec 10, 2025 that may be closed by this pull request
@gmalinve
Copy link
Contributor Author

@SMoraisAnsys @Samuelopez-ansys is there a reason why we don't have anymore fields_calculator tests? I remember we had them in the past. Am I missing something?

eblanco-ansys
eblanco-ansys previously approved these changes Dec 10, 2025
@github-actions github-actions bot added the enhancement New features or code improvements label Dec 10, 2025
eblanco-ansys
eblanco-ansys previously approved these changes Dec 10, 2025
@gmalinve gmalinve marked this pull request as draft December 10, 2025 14:38
@gmalinve gmalinve changed the title FEAT: add fields calc expressions FEAT: add fields calc expressions and update fields distribution extension Dec 10, 2025
@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.07%. Comparing base (a123a1c) to head (f0ca145).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6996      +/-   ##
==========================================
- Coverage   83.51%   82.07%   -1.45%     
==========================================
  Files         254      254              
  Lines       77338    77348      +10     
==========================================
- Hits        64590    63482    -1108     
- Misses      12748    13866    +1118     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gmalinve gmalinve linked an issue Dec 19, 2025 that may be closed by this pull request
@gmalinve gmalinve linked an issue Dec 22, 2025 that may be closed by this pull request
SMoraisAnsys
SMoraisAnsys previously approved these changes Jan 8, 2026
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left some minor comment mainly over:

  1. Splitting a test into 3 parts for readability: setup, exercise, assert (we don't need a teardown)
  2. Asking to move the patchs outside of the test content (as decorator) to ease readability

Thanks again for this changes @gmalinve

Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
gmalinve and others added 14 commits January 8, 2026 14:29
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
gmalinve and others added 3 commits January 9, 2026 13:12
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmalinve gmalinve merged commit 88b878b into main Jan 12, 2026
42 checks passed
@gmalinve gmalinve deleted the feat/get_fields_expressions branch January 12, 2026 07:49
@gmalinve gmalinve linked an issue Jan 12, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements extensions

Projects

None yet

6 participants