FIX: remove un-needed warning message when modifying mesh regions by lorenzovecchietti · Pull Request #7033 · ansys/pyaedt

lorenzovecchietti · 2025-12-19T10:56:08Z

codecov · 2025-12-19T11:07:31Z

Codecov Report

❌ Patch coverage is 42.85714% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 23.34%. Comparing base (d7025d5) to head (16d2f24).
⚠️ Report is 4 commits behind head on main.

❌ Your patch status has failed because the patch coverage (42.85%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #7033       +/-   ##
===========================================
- Coverage   83.62%   23.34%   -60.28%     
===========================================
  Files         253      252        -1     
  Lines       77348    77303       -45     
===========================================
- Hits        64679    18050    -46629     
- Misses      12669    59253    +46584

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

src/ansys/aedt/core/modules/mesh_icepak.py

- add context manager to suspend logging - add property and setter for log status - leverage context manager

Samuelopez-ansys · 2025-12-29T13:42:40Z

This is Ok, but please could you add tests?

src/ansys/aedt/core/aedt_logger.py

MaxJPRey

LGMT.

Co-authored-by: Maxime Rey <87315832+MaxJPRey@users.noreply.github.com>

Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>

Samuelopez-ansys · 2026-01-08T13:35:14Z

Hi @lorenzovecchietti , could you check the tests? Something is not working

lorenzovecchietti · 2026-01-14T11:17:22Z

Hi @lorenzovecchietti , could you check the tests? Something is not working

Unfortunately, everything is working on my side.

I'm trying to investigate, but I'm worried these are failure due to instability crashes.

Samuelopez-ansys

LGTM

lorenzovecchietti · 2026-01-20T11:48:48Z

@Samuelopez-ansys Thanks for the help!

SMoraisAnsys

LGTM

tests/system/general/test_message_manager.py

Samuelopez-ansys · 2026-01-21T07:15:21Z

This PR is corrupted on GitHub, so I will close it, and I opened a new one:

#7123

Fix un-needed warning message when modifying mesh regions

5252b04

github-actions bot added the bug Something isn't working label Dec 19, 2025

pyansys-ci-bot and others added 2 commits December 19, 2025 10:57

chore: adding changelog file 7033.fixed.md [dependabot-skip]

8c9e9ea

Merge branch 'main' into fix-warnings

b5b011b

Merge branch 'main' into fix-warnings

9dae0d1

lorenzovecchietti marked this pull request as ready for review December 22, 2025 11:08

lorenzovecchietti requested a review from a team as a code owner December 22, 2025 11:08

lorenzovecchietti added 2 commits December 22, 2025 13:40

Fix codacity error

2b09411

Merge remote-tracking branch 'origin/fix-warnings' into fix-warnings

a51dde3

Samuelopez-ansys requested changes Dec 22, 2025

View reviewed changes

src/ansys/aedt/core/modules/mesh_icepak.py Outdated Show resolved Hide resolved

lorenzovecchietti and others added 3 commits December 24, 2025 09:44

Improve style

a89c23e

- add context manager to suspend logging - add property and setter for log status - leverage context manager

Merge branch 'main' into fix-warnings

4d9b8ca

Add context manager inside the Aedtlogger class

6aa1e91

Samuelopez-ansys marked this pull request as draft December 29, 2025 13:47

lorenzovecchietti and others added 2 commits December 30, 2025 09:46

Merge branch 'main' into fix-warnings

8e8309a

Improve coverage

7a05227

lorenzovecchietti marked this pull request as ready for review December 30, 2025 10:06

CHORE: Auto fixes from pre-commit hooks

6e1e42d

MaxJPRey reviewed Dec 31, 2025

View reviewed changes

src/ansys/aedt/core/aedt_logger.py Outdated Show resolved Hide resolved

MaxJPRey reviewed Dec 31, 2025

View reviewed changes

src/ansys/aedt/core/aedt_logger.py Outdated Show resolved Hide resolved

MaxJPRey reviewed Dec 31, 2025

View reviewed changes

src/ansys/aedt/core/aedt_logger.py Outdated Show resolved Hide resolved

MaxJPRey previously approved these changes Dec 31, 2025

View reviewed changes

Update src/ansys/aedt/core/aedt_logger.py

6ef88ac

Co-authored-by: Maxime Rey <87315832+MaxJPRey@users.noreply.github.com>

lorenzovecchietti dismissed MaxJPRey’s stale review via 6ef88ac December 31, 2025 13:43

lorenzovecchietti and others added 3 commits December 31, 2025 14:43

Update src/ansys/aedt/core/aedt_logger.py

b7103b9

Co-authored-by: Maxime Rey <87315832+MaxJPRey@users.noreply.github.com>

Update src/ansys/aedt/core/aedt_logger.py

fe8e051

Co-authored-by: Maxime Rey <87315832+MaxJPRey@users.noreply.github.com>

Merge branch 'main' into fix-warnings

6c425b3

lorenzovecchietti enabled auto-merge (squash) December 31, 2025 13:43

lorenzovecchietti marked this pull request as draft January 7, 2026 08:40

auto-merge was automatically disabled January 7, 2026 08:40
Pull request was converted to draft

lorenzovecchietti and others added 3 commits January 7, 2026 09:40

Merge branch 'main' into fix-warnings

92618d1

Update src/ansys/aedt/core/aedt_logger.py

ff7fef5

Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>

improve tests

fdfbf01

lorenzovecchietti marked this pull request as ready for review January 7, 2026 09:12

lorenzovecchietti and others added 5 commits January 15, 2026 15:06

Merge branch 'main' into fix-warnings

20e2989

Merge branch 'main' into fix-warnings

e9f5d2a

Delete logger setting

30ae891

Keep only icepak

d6ad9ae

Logging check

e5e9a6c

github-actions bot added the maintenance Package and maintenance related label Jan 19, 2026

Samuelopez-ansys added 5 commits January 19, 2026 16:26

Logging check

1c010b9

enabling settings.enable_desktop_logs

02a5ad6

Skip if suspend_logic not available

70d2c92

Revert cicd

7adeea0

Revert cicd

16d2f24

Samuelopez-ansys approved these changes Jan 20, 2026

View reviewed changes

Samuelopez-ansys enabled auto-merge (squash) January 20, 2026 10:15

auto-merge was automatically disabled January 20, 2026 10:21
Pull Request is not mergeable

Samuelopez-ansys enabled auto-merge (squash) January 20, 2026 11:55

auto-merge was automatically disabled January 20, 2026 12:25
Pull Request is not mergeable

SMoraisAnsys approved these changes Jan 20, 2026

View reviewed changes

tests/system/general/test_message_manager.py Show resolved Hide resolved

Samuelopez-ansys enabled auto-merge (squash) January 20, 2026 17:10

Samuelopez-ansys disabled auto-merge January 20, 2026 17:11

Samuelopez-ansys closed this Jan 21, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FIX: remove un-needed warning message when modifying mesh regions#7033

FIX: remove un-needed warning message when modifying mesh regions#7033
lorenzovecchietti wants to merge 31 commits intomainfrom
fix-warnings

lorenzovecchietti commented Dec 19, 2025

Uh oh!

codecov bot commented Dec 19, 2025 •

edited

Loading

Uh oh!

Uh oh!

Samuelopez-ansys commented Dec 29, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MaxJPRey left a comment

Uh oh!

Samuelopez-ansys commented Jan 8, 2026

Uh oh!

lorenzovecchietti commented Jan 14, 2026

Uh oh!

Samuelopez-ansys left a comment

Uh oh!

lorenzovecchietti commented Jan 20, 2026

Uh oh!

SMoraisAnsys left a comment

Uh oh!

Uh oh!

Samuelopez-ansys commented Jan 21, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

lorenzovecchietti commented Dec 19, 2025

Uh oh!

codecov bot commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Samuelopez-ansys commented Dec 29, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MaxJPRey left a comment

Choose a reason for hiding this comment

Uh oh!

Samuelopez-ansys commented Jan 8, 2026

Uh oh!

lorenzovecchietti commented Jan 14, 2026

Uh oh!

Samuelopez-ansys left a comment

Choose a reason for hiding this comment

Uh oh!

lorenzovecchietti commented Jan 20, 2026

Uh oh!

SMoraisAnsys left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Samuelopez-ansys commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented Dec 19, 2025 •

edited

Loading

Samuelopez-ansys commented Jan 21, 2026 •

edited

Loading