Skip to content

Conversation

AlejandroFernandezLuces
Copy link
Contributor

@AlejandroFernandezLuces AlejandroFernandezLuces commented Nov 20, 2024

Fixes issues raised in #528 (comment)

@github-actions github-actions bot added documentation Improvements or additions to documentation bug Something isn't working labels Nov 20, 2024
@AlejandroFernandezLuces AlejandroFernandezLuces marked this pull request as ready for review November 20, 2024 08:43
Co-authored-by: Roberto Pastor Muela <[email protected]>
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for @greschd

Copy link
Member

@greschd greschd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I also like that the regex is now more understandable 🙂

@AlejandroFernandezLuces AlejandroFernandezLuces enabled auto-merge (squash) November 20, 2024 10:24
@AlejandroFernandezLuces AlejandroFernandezLuces merged commit 1722124 into main Nov 20, 2024
9 checks passed
@AlejandroFernandezLuces AlejandroFernandezLuces deleted the fix/ruleset-issues branch November 20, 2024 10:27
github-actions bot pushed a commit that referenced this pull request Nov 20, 2024
* fix: Branch name protection fixes

* Apply suggestions from code review

Co-authored-by: Roberto Pastor Muela <[email protected]>

* fix: Add suggested new names

* doc: Add new names to the contributing guide

* Update doc/source/_rulesets/branch_naming.json

Co-authored-by: Roberto Pastor Muela <[email protected]>

---------

Co-authored-by: Roberto Pastor Muela <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants