feat: facilitating example contribution #596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
SMoraisAnsys
approved these changes
May 9, 2025
There was a problem hiding this comment.
LGTM. @RobPasMue would it be worth adding a bit of content about creating examples with jupytext since you are updating the documentation on examples ? If you want I can add that in a follow-up, in this PR or not at all :D
|
Please add it to this PR! That would be super useful -- would you mind adding it? |
klmcadams
reviewed
May 9, 2025
Co-authored-by: Kerry McAdams <[email protected]>
|
@RobPasMue I've added content for the Jupytext approach. Let me know if it needs to be updated :) |
RobPasMue
commented
May 15, 2025
RobPasMue
commented
May 15, 2025
Co-authored-by: Roberto Pastor Muela <[email protected]>
clatapie
approved these changes
May 15, 2025
There was a problem hiding this comment.
I left a few comments, other than that: it looks good to me, thanks @RobPasMue!
Co-authored-by: Camille Latapie <[email protected]>
RobPasMue
commented
May 16, 2025
SMoraisAnsys
approved these changes
May 17, 2025
github-actions bot
pushed a commit
that referenced
this pull request
May 17, 2025
* feat: facilitating example contribution * feat: enhancements * Update doc/source/how-to/documenting.rst Co-authored-by: Kerry McAdams <[email protected]> * docs: extend with jupytext approach * fix(docs): wrong link for pyspeos * Apply suggestions from code review Co-authored-by: Roberto Pastor Muela <[email protected]> * refactor: use links file * Update doc/source/how-to/documenting.rst Co-authored-by: Camille Latapie <[email protected]> * Update doc/source/how-to/documenting.rst * Update doc/source/how-to/documenting.rst --------- Co-authored-by: Kerry McAdams <[email protected]> Co-authored-by: Sebastien Morais <[email protected]> Co-authored-by: Sébastien Morais <[email protected]> Co-authored-by: Camille Latapie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #595