adding dict return typehint

removing offset_face_curves

Author: jacobrkerstetter

src/ansys/geometry/core/_grpc/_services/base/curves.py

@@ -40,6 +40,6 @@ def __init__(self, channel: grpc.Channel):
         pass
 
     @abstractmethod
-    def offset_face_curves(self, **kwargs) -> dict:
-        """Offset face curves."""
+    def revolve_edges(self, **kwargs) -> dict:
+        """Revolve edges around an axis to create a surface of revolution."""
         pass

src/ansys/geometry/core/_grpc/_services/v0/curves.py

@@ -50,27 +50,7 @@ def __init__(self, channel: grpc.Channel):  # noqa: D102
         self.stub = CommandsStub(channel)
 
     @protect_grpc
-    def offset_face_curves(self, **kwargs):  # noqa: D102
-        from ansys.api.dbu.v0.dbumodels_pb2 import EntityIdentifier
-        from ansys.api.geometry.v0.commands_pb2 import OffsetFaceCurvesRequest
-
-        # Create the request - assumes all inputs are valid and of the proper type
-        request = OffsetFaceCurvesRequest(
-            objects=[EntityIdentifier(id=id) for id in kwargs["curve_ids"]],
-            offset=from_measurement_to_server_length(kwargs["offset"]),
-        )
-        
-        # Call the gRPC service
-        result = self.stub.OffsetFaceCurves(request)
-
-        # Return the result - formatted as a dictionary
-        return {
-            "success": result.result.success,
-            "created_curves": [curve.id for curve in result.created_curves]
-        }
-
-    @protect_grpc
-    def revolve_edges(self, **kwargs):  # noqa: D102
+    def revolve_edges(self, **kwargs) -> dict:  # noqa: D102
         from ansys.api.geometry.v0.commands_pb2 import RevolveCurvesRequest
 
         # Create the request - assumes all inputs are valid and of the proper type

src/ansys/geometry/core/_grpc/_services/v0/faces.py

@@ -281,7 +281,7 @@ def create_iso_parametric_curve(self, **kwargs) -> dict:  # noqa: D102
         }
 
     @protect_grpc
-    def extrude_faces(self, **kwargs):  # noqa: D102
+    def extrude_faces(self, **kwargs) -> dict:  # noqa: D102
         from ansys.api.dbu.v0.dbumodels_pb2 import EntityIdentifier
         from ansys.api.geometry.v0.commands_pb2 import ExtrudeFacesRequest
 
@@ -314,7 +314,7 @@ def extrude_faces(self, **kwargs):  # noqa: D102
         }
 
     @protect_grpc
-    def extrude_faces_up_to(self, **kwargs):  # noqa: D102
+    def extrude_faces_up_to(self, **kwargs) -> dict:  # noqa: D102
         from ansys.api.dbu.v0.dbumodels_pb2 import EntityIdentifier
         from ansys.api.geometry.v0.commands_pb2 import ExtrudeFacesUpToRequest
 
@@ -503,7 +503,7 @@ def draft_faces(self, **kwargs) -> dict:  # noqa: D102
         }
 
     @protect_grpc
-    def get_round_info(self, **kwargs):  # noqa: D102
+    def get_round_info(self, **kwargs) -> dict:  # noqa: D102
         from ansys.api.dbu.v0.dbumodels_pb2 import EntityIdentifier
         from ansys.api.geometry.v0.commands_pb2 import RoundInfoRequest
 

src/ansys/geometry/core/_grpc/_services/v1/curves.py

@@ -46,11 +46,7 @@ def __init__(self, channel: grpc.Channel):  # noqa: D102
         from ansys.api.geometry.v1.curves_pb2_grpc import CurvesStub
 
         self.stub = CurvesStub(channel)
-
-    @protect_grpc
-    def offset_face_curves(self, **kwargs):  # noqa: D102
-        raise NotImplementedError
 
     @protect_grpc
-    def revolve_edges(self, **kwargs):  # noqa: D102
+    def revolve_edges(self, **kwargs) -> dict:  # noqa: D102
         raise NotImplementedError

src/ansys/geometry/core/designer/geometry_commands.py

@@ -1794,34 +1794,6 @@ def offset_faces(
             extrude_type=extrude_type,
         )
 
-    @min_backend_version(25, 2, 0)
-    def offset_face_curves(
-        self,
-        curves: Union["Curve", list["Curve"]],
-        offset: Distance | Quantity | Real,
-    ) -> bool:
-        """Offsets a given set of face curves by the specified distance.
-
-        Parameters
-        ----------
-        curves : Curve | list[Curve]
-            The curves to offset.
-        offset : Distance | Quantity | Real
-            The distance to offset the curves.
-        
-        Returns
-        -------
-        bool
-            ``True`` when successful, ``False`` when failed.
-        """
-        curves = curves if isinstance(curves, list) else [curves]
-        offset = offset if isinstance(offset, Distance) else Distance(offset)
-
-        _ = self._grpc_client._services.curves.offset_face_curves(
-            curves=[curve.id for curve in curves], # TODO
-            offset=offset
-        )
-
     @min_backend_version(25, 2, 0)
     def revolve_edges(
         self,