Skip to content

Conversation

@RobPasMue
Copy link
Member

Description

After #1481 a lot of numpydoc warnings started to show up. Let's fix them whenever possible

Issue linked

None

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Nov 27, 2024
@github-actions github-actions bot added the bug Something isn't working label Nov 27, 2024
@codecov
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.60%. Comparing base (8d9d805) to head (7faa059).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/geometry/core/designer/body.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1556   +/-   ##
=======================================
  Coverage   91.60%   91.60%           
=======================================
  Files          86       86           
  Lines        7051     7051           
=======================================
  Hits         6459     6459           
  Misses        592      592           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobPasMue RobPasMue marked this pull request as ready for review November 27, 2024 15:44
@RobPasMue RobPasMue requested a review from a team as a code owner November 27, 2024 15:44
@RobPasMue
Copy link
Member Author

Merging since warnings have been fixed or ignored (built-ins causing failure... not our problem)

@RobPasMue RobPasMue merged commit 7ab4a01 into main Nov 27, 2024
43 of 44 checks passed
@RobPasMue RobPasMue deleted the fix/numpydoc-warnings branch November 27, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants