-
Notifications
You must be signed in to change notification settings - Fork 22
feat: repair tools refactoring #1912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 61 commits
Commits
Show all changes
76 commits
Select commit
Hold shift + click to select a range
51671c6
repair tools refactoring
umutsoysalansys e3e239d
chore: auto fixes from pre-commit hooks
pre-commit-ci[bot] 709e57a
chore: adding changelog file 1912.added.md [dependabot-skip]
pyansys-ci-bot df56e2c
Merge branch 'main' into feat/grpc-common-layer-refactoring
umutsoysalansys 41e790a
repair tools
umutsoysalansys 40b5941
Merge branch 'feat/grpc-common-layer-refactoring' of https://github.c…
umutsoysalansys e158532
remove repair stubs
umutsoysalansys 539c33b
missing_face
umutsoysalansys 6b1b9e1
merge
umutsoysalansys 90b254a
Merge branch 'main' into feat/grpc-common-layer-refactoring
umutsoysalansys 0021a55
chore: auto fixes from pre-commit hooks
pre-commit-ci[bot] a671293
revert delete
umutsoysalansys 1817fef
Merge branch 'feat/grpc-common-layer-refactoring' of https://github.c…
umutsoysalansys 2dacd8b
chore: auto fixes from pre-commit hooks
pre-commit-ci[bot] 0595318
implement missing methods
umutsoysalansys fddd6c2
chore: auto fixes from pre-commit hooks
pre-commit-ci[bot] 81908d9
interference fix
umutsoysalansys c0dcca5
Merge branch 'feat/grpc-common-layer-refactoring' of https://github.c…
umutsoysalansys 47479c4
chore: auto fixes from pre-commit hooks
pre-commit-ci[bot] be96550
Merge branch 'main' into feat/grpc-common-layer-refactoring
umutsoysalansys 4cad96a
precommit
umutsoysalansys 6ce6e10
Merge branch 'feat/grpc-common-layer-refactoring' of https://github.c…
umutsoysalansys e90b1f5
doc fix
umutsoysalansys abe2353
decorator fix
umutsoysalansys f4e167d
doc fix
umutsoysalansys b4f930c
chore: auto fixes from pre-commit hooks
pre-commit-ci[bot] 6a5c2d1
Update repair_tools.py
umutsoysalansys 7e3bd01
Merge branch 'feat/grpc-common-layer-refactoring' of https://github.c…
umutsoysalansys 63ce51e
docfix
umutsoysalansys 088ed09
Merge branch 'main' into feat/grpc-common-layer-refactoring
umutsoysalansys cac418a
doc fix
umutsoysalansys b4594f9
nits bits
umutsoysalansys 53c09b3
bs
umutsoysalansys 9c693bb
chore: auto fixes from pre-commit hooks
pre-commit-ci[bot] 36d9136
bs
umutsoysalansys c2baffc
Merge branch 'feat/grpc-common-layer-refactoring' of https://github.c…
umutsoysalansys 0b898dc
Merge branch 'main' into feat/grpc-common-layer-refactoring
umutsoysalansys 5a0f9f9
refactoring
umutsoysalansys 4849d47
name
umutsoysalansys 45a2403
Update repair_tools.py
umutsoysalansys 5414cad
chore: auto fixes from pre-commit hooks
pre-commit-ci[bot] 8646ad1
response refactor
umutsoysalansys 56f5671
chore: auto fixes from pre-commit hooks
pre-commit-ci[bot] 2c650d5
further ref
umutsoysalansys 984819e
Merge branch 'feat/grpc-common-layer-refactoring' of https://github.c…
umutsoysalansys 10587e5
further refctrng
umutsoysalansys 3e5589d
Update repair_tools.py
umutsoysalansys 7e20d8e
blind push bc this test is not working in discovery
umutsoysalansys 6b744f1
chore: auto fixes from pre-commit hooks
pre-commit-ci[bot] cc00bba
updates
umutsoysalansys 0fe131b
chore: auto fixes from pre-commit hooks
pre-commit-ci[bot] 7ad68f9
removal of unused files
umutsoysalansys cb9a20d
chore: auto fixes from pre-commit hooks
pre-commit-ci[bot] 2d69f13
further simplifications
umutsoysalansys 44ac1e4
Merge branch 'feat/grpc-common-layer-refactoring' of https://github.c…
umutsoysalansys 68e1047
chore: auto fixes from pre-commit hooks
pre-commit-ci[bot] 1b004b5
further simplifications
umutsoysalansys 6d3d9b7
Merge branch 'feat/grpc-common-layer-refactoring' of https://github.c…
umutsoysalansys 6116244
chore: auto fixes from pre-commit hooks
pre-commit-ci[bot] 40f84ae
Update repair_tools.py
umutsoysalansys 2fc6351
Merge branch 'feat/grpc-common-layer-refactoring' of https://github.c…
umutsoysalansys 06e7fdf
Update src/ansys/geometry/core/_grpc/_services/base/repair_tools.py
umutsoysalansys 966fbc4
chore: auto fixes from pre-commit hooks
pre-commit-ci[bot] 38d0e04
Update src/ansys/geometry/core/_grpc/_services/v0/repair_tools.py
umutsoysalansys 2ae7674
Update src/ansys/geometry/core/_grpc/_services/v0/repair_tools.py
umutsoysalansys 1872350
Update src/ansys/geometry/core/_grpc/_services/v0/repair_tools.py
umutsoysalansys a67f5df
Update src/ansys/geometry/core/_grpc/_services/v0/repair_tools.py
umutsoysalansys f8e5454
Update src/ansys/geometry/core/_grpc/_services/v0/repair_tools.py
umutsoysalansys b1e17da
Merge branch 'main' into feat/grpc-common-layer-refactoring
umutsoysalansys c82e490
more refct
umutsoysalansys 51e5c54
Merge branch 'main' into feat/grpc-common-layer-refactoring
umutsoysalansys c3e5c98
Update repair_tools.py
umutsoysalansys 0362a17
Update repair_tools.py
umutsoysalansys 8c49791
chore: auto fixes from pre-commit hooks
pre-commit-ci[bot] e9bd066
noqa
umutsoysalansys 0504552
codality wtf
umutsoysalansys File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| repair tools refactoring |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
128 changes: 128 additions & 0 deletions
128
src/ansys/geometry/core/_grpc/_services/base/repair_tools.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,128 @@ | ||
| # Copyright (C) 2023 - 2025 ANSYS, Inc. and/or its affiliates. | ||
| # SPDX-License-Identifier: MIT | ||
| # | ||
| # | ||
| # Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| # of this software and associated documentation files (the "Software"), to deal | ||
| # in the Software without restriction, including without limitation the rights | ||
| # to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| # copies of the Software, and to permit persons to whom the Software is | ||
| # furnished to do so, subject to the following conditions: | ||
| # | ||
| # The above copyright notice and this permission notice shall be included in all | ||
| # copies or substantial portions of the Software. | ||
| # | ||
| # THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| # IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| # FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| # AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| # LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| # SOFTWARE. | ||
| """Module containing the repair tools service implementation (abstraction layer). | ||
|
|
||
| This module defines an abstract base class for a gRPC-based repair tools service. | ||
| The class provides a set of abstract methods for identifying and repairing various | ||
| geometry issues, such as split edges, extra edges, duplicate faces, and more. | ||
| """ | ||
|
|
||
| from abc import ABC, abstractmethod | ||
|
|
||
| import grpc | ||
|
|
||
|
|
||
| class GRPCRepairToolsService(ABC): | ||
| """Abstract base class for gRPC-based repair tools service. | ||
|
|
||
| Defines abstract methods for identifying and repairing geometry issues in a model. | ||
| """ | ||
|
|
||
| def __init__(self, channel: grpc.Channel): | ||
| """Initialize the gRPC repair tools service. | ||
|
|
||
| Parameters | ||
| ---------- | ||
| channel: grpc.Channel | ||
| The gRPC channel used to communicate with the service. | ||
| """ | ||
| pass # pragma: no cover | ||
|
|
||
| @abstractmethod | ||
| def find_split_edges(self, **kwargs) -> dict: | ||
| """Identify split edges in the geometry.""" | ||
| pass # pragma: no cover | ||
|
|
||
| @abstractmethod | ||
| def find_extra_edges(self, **kwargs) -> dict: | ||
| """Identify extra edges in the geometry.""" | ||
| pass # pragma: no cover | ||
|
|
||
| @abstractmethod | ||
| def find_inexact_edges(self, **kwargs) -> dict: | ||
| """Identify inexact edges in the geometry.""" | ||
| pass # pragma: no cover | ||
|
|
||
| @abstractmethod | ||
| def find_short_edges(self, **kwargs) -> dict: | ||
| """Identify short edges in the geometry.""" | ||
| pass # pragma: no cover | ||
|
|
||
| @abstractmethod | ||
| def find_duplicate_faces(self, **kwargs) -> dict: | ||
| """Identify duplicate faces in the geometry.""" | ||
| pass # pragma: no cover | ||
|
|
||
| @abstractmethod | ||
| def find_missing_faces(self, **kwargs) -> dict: | ||
| """Identify missing faces in the geometry.""" | ||
| pass # pragma: no cover | ||
|
|
||
| @abstractmethod | ||
| def find_small_faces(self, **kwargs) -> dict: | ||
| """Identify small faces in the geometry.""" | ||
| pass # pragma: no cover | ||
|
|
||
| @abstractmethod | ||
| def find_stitch_faces(self, **kwargs) -> dict: | ||
| """Identify faces that can be stitched together in the geometry.""" | ||
| pass # pragma: no cover | ||
|
|
||
| @abstractmethod | ||
| def find_simplify(self, **kwargs) -> dict: | ||
| """Identify areas in the geometry that can be simplified.""" | ||
| pass # pragma: no cover | ||
|
|
||
| @abstractmethod | ||
| def find_interferences(self, **kwargs) -> dict: | ||
| """Identify interferences in the geometry.""" | ||
| pass # pragma: no cover | ||
|
|
||
| @abstractmethod | ||
| def find_and_fix_short_edges(self, **kwargs) -> dict: | ||
| """Identify and fix short edges in the geometry.""" | ||
| pass # pragma: no cover | ||
|
|
||
| @abstractmethod | ||
| def find_and_fix_extra_edges(self, **kwargs) -> dict: | ||
| """Identify and fix extra edges in the geometry.""" | ||
| pass # pragma: no cover | ||
|
|
||
| @abstractmethod | ||
| def find_and_fix_split_edges(self, **kwargs) -> dict: | ||
| """Identify and fix split edges in the geometry.""" | ||
| pass # pragma: no cover | ||
|
|
||
| @abstractmethod | ||
| def find_and_fix_simplify(self, **kwargs) -> dict: | ||
| """Identify and simplify areas in the geometry.""" | ||
| pass # pragma: no cover | ||
|
|
||
| @abstractmethod | ||
| def inspect_geometry(self, **kwargs) -> dict: | ||
| """Inspect the geometry for issues.""" | ||
| pass # pragma: no cover | ||
|
|
||
| @abstractmethod | ||
| def repair_geometry(self, **kwargs) -> dict: | ||
| """Repair the geometry by addressing identified issues.""" | ||
| pass # pragma: no cover | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.