-
Notifications
You must be signed in to change notification settings - Fork 22
feat: grpc driving dimensions stub implementation #1921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: grpc driving dimensions stub implementation #1921
Conversation
adjusted usages to call stub
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1921 +/- ##
==========================================
- Coverage 90.39% 90.36% -0.03%
==========================================
Files 114 117 +3
Lines 9545 9593 +48
==========================================
+ Hits 8628 8669 +41
- Misses 917 924 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…hub.com/ansys/pyansys-geometry into feat/driving_dimensions_stub_relocation
src/ansys/geometry/core/_grpc/_services/v0/driving_dimensions.py
Outdated
Show resolved
Hide resolved
|
Blocked by #1924 |
… feat/driving_dimensions_stub_relocation # Conflicts: # src/ansys/geometry/core/parameters/parameter.py
…hub.com/ansys/pyansys-geometry into feat/driving_dimensions_stub_relocation
RobPasMue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Merging!
Description
Issue linked
#1817
Checklist
feat: extrude circle to cylinder)