Skip to content

Conversation

@smereu
Copy link
Contributor

@smereu smereu commented Aug 5, 2025

Description

This pull request contains the following changes

  • Enable the boolean operation to track changes. When tracking changes it skips clean-up operation on the python side since all the logic resides in the SC APIs.
  • Clean-up code to have a single implementation for serializing the tracked changes.
  • Fixes to the tracker code that deals with added/deleted bodies to keep into account the fact we are caching the bodies so the update needs to be done on the actual data. Also remove use of guids rather than object ids, which prevent proper matching

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@smereu smereu requested a review from a team as a code owner August 5, 2025 18:40
@smereu
Copy link
Contributor Author

smereu commented Aug 5, 2025

This PR needs an update of Core Service code before it can be merged

@github-actions github-actions bot added the enhancement New features or code improvements label Aug 5, 2025
@codecov
Copy link

codecov bot commented Aug 5, 2025

Codecov Report

❌ Patch coverage is 70.35398% with 67 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.50%. Comparing base (b94575b) to head (d99e24f).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...c/ansys/geometry/core/_grpc/_services/v0/bodies.py 27.90% 31 Missing ⚠️
src/ansys/geometry/core/designer/design.py 0.00% 19 Missing ⚠️
src/ansys/geometry/core/tools/problem_areas.py 77.27% 10 Missing ⚠️
src/ansys/geometry/core/designer/body.py 57.14% 6 Missing ⚠️
...c/ansys/geometry/core/tools/repair_tool_message.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2153      +/-   ##
==========================================
- Coverage   94.52%   94.50%   -0.02%     
==========================================
  Files         169      169              
  Lines       11034    11109      +75     
==========================================
+ Hits        10430    10499      +69     
- Misses        604      610       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RobPasMue RobPasMue changed the title Feat/track boolean operations feat: tracking boolean operations Aug 11, 2025
@RobPasMue
Copy link
Member

@jacobrkerstetter @smereu -- tracker tests are still failing (although it might be related to my last comment #2153 (comment))

Make sure they pass again as part of this PR since we are dealing with the tracker directly.

jacobrkerstetter and others added 4 commits September 3, 2025 11:05
This Pr addresses a couple of missing items in handling the return argument of the tracker and makes steps toward consolidating in the proper place the tracker code. More clean-up to come in follow-up PRs
pre-commit-ci bot and others added 25 commits September 25, 2025 17:04
Adjust to name change after merging PR
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Amazing job @smereu !!

@RobPasMue RobPasMue merged commit 4a59f05 into main Oct 2, 2025
87 of 100 checks passed
@RobPasMue RobPasMue deleted the feat/track_boolean_operations branch October 2, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants