-
Notifications
You must be signed in to change notification settings - Fork 22
feat: tracking boolean operations #2153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR contains the following changes - Client side change for boolean to remove delete on the python side (now done in the SC API) and update from response - Changes to add and delete body logic for proper dealing with @cached_property implementation of the function that get bodies - Small refactoring to avoid multiple definition of the function _serialize_tracker_command_response
|
This PR needs an update of Core Service code before it can be merged |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2153 +/- ##
==========================================
- Coverage 94.52% 94.50% -0.02%
==========================================
Files 169 169
Lines 11034 11109 +75
==========================================
+ Hits 10430 10499 +69
- Misses 604 610 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@jacobrkerstetter @smereu -- tracker tests are still failing (although it might be related to my last comment #2153 (comment)) Make sure they pass again as part of this PR since we are dealing with the tracker directly. |
This Pr addresses a couple of missing items in handling the return argument of the tracker and makes steps toward consolidating in the proper place the tracker code. More clean-up to come in follow-up PRs
Adjust to name change after merging PR
…sys/pyansys-geometry into feat/track_boolean_operations
…sys/pyansys-geometry into feat/track_boolean_operations
…sys/pyansys-geometry into feat/track_boolean_operations
…sys/pyansys-geometry into feat/track_boolean_operations
RobPasMue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Amazing job @smereu !!
Description
This pull request contains the following changes
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist
feat: extrude circle to cylinder)